| 1 |
On Apr 6, 2013 2:36 PM, "Alexandre Rostovtsev" <tetromino@g.o> wrote: |
| 2 |
> |
| 3 |
> On Sat, 2013-04-06 at 20:08 +0200, Michał Górny wrote: |
| 4 |
> > 2. Patches have to apply to the top directory of the source tree with |
| 5 |
> > 'patch -p1'. If patches are applied to sub-directories, necessary '-p' |
| 6 |
> > argument shall be passed to 'epatch' explicitly. Developers are |
| 7 |
> > encouraged to create patches which are compatible with 'git am'. |
| 8 |
> |
| 9 |
> Please don't make -p1 into a hard requirement :/ |
| 10 |
> |
| 11 |
> There are upstreams who have different directory layouts in their scm |
| 12 |
> tree and in their source tarballs. If I clone an upstream git repository |
| 13 |
> to obtain a patch or to write a new patch that I will submit upstream, I |
| 14 |
> want to be able to apply that patch in an ebuild without having to |
| 15 |
> manually sed it to change the -p level. |
| 16 |
> |
| 17 |
> Specific examples of this among packages that I maintain: app-cdr/cdemu, |
| 18 |
> app-cdr/cdemu-daemon, sys-fs/vhba. These all use the same git tree, and |
| 19 |
> source tarballs for individual packages are created from different |
| 20 |
> subdirectories of that git tree. |
| 21 |
> |
| 22 |
> |
| 23 |
|
| 24 |
It wouldn't be; you pass the p level in as an argument, if necessary. |
Archives