Re: [gentoo-dev] variable quoting, setting optional variables to "", and depending on virtual/libc

[Donnie Berkholz]

Thomas Cort wrote:
> What is the proper quoting style for using epatch? In the tree there
> are about 3 different styles...
>
> 	epatch ${FILESDIR}/some-fix.patch      # used by 7326 ebuilds
> 	epatch "${FILESDIR}"/some-fix.patch    # used by 3092 ebuilds
> 	epatch "${FILESDIR}/some-fix.patch"    # used by 1434 ebuilds
>
> What is the proper quoting style for defining the S variable? In the
> tree there are about 3 different styles...
>
> 	S=${WORKDIR}/${MY_P}    # used by 5270 ebuilds
> 	S="${WORKDIR}"/${MY_P}  # used by 43 ebuilds
> 	S="${WORKDIR}/${MY_P}"  # used by 2259 ebuilds

The reasoning for quoting here is at least twofold:

1) There may be spaces in paths (e.g. PORTDIR and PORTAGE_TMPDIR), so
you need to use quotes.
2) When you set a variable to a string, you should use quotes.

Older ebuilds probably mostly lack quoting around uses of $FILESDIR, $S
and $D in the ebuild.

Thanks,
Donnie