Gentoo Archives: gentoo-dev

From: "Bo Ørsted Andresen" <zlin@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] explicit -r0 in ebuild filename
Date: Fri, 04 Apr 2008 06:39:37
Message-Id: 200804040839.22382.zlin@gentoo.org
In Reply to: Re: [gentoo-dev] explicit -r0 in ebuild filename by Brian Harring
1 On Monday 31 March 2008 02:29:10 Brian Harring wrote:
2 > Going to reiterate this one more time; the proposal is simple enough;
3 > if it's an implicit 0 via cpv parsing, it should *not* be explicitly
4 > specified on disk. 'diffball-1.0_alpha0.ebuild' can just as easily be
5 > specified as 'diffball-1.0_alpha.ebuild', 'diffball-1.0-r0.ebuild' can
6 > just as easily be specified as 'diffball-1.0.ebuild'.
7 >
8 > Reiterating the gain: consistancy on disk, consistancy in dealing with
9 > PV/PVR. As you keep point out, PV does vary- having the results of
10 > ebuild execution change depending on whether or not you name your
11 > ebuild 'diffball-1.0_alpha0.ebuild' or 'diffball-1.0_alpha.ebuild' is
12 > *not* a feature, it is what you would classically call a "design
13 > misfeature". PVR for 'diffball-1.0-r0.ebuild' being '1.0' instead of
14 > '1.0-r0' is yet another argument for punting explicit -r0 on disk-
15 > it's a gotcha, design flaw in the format.
16 >
17 > It's a simple tweak, with no real loss of functionality (lots of
18 > claims, no single hard proof thus far). As spanky has stated, there
19 > *is* a loss of ease of use in a small subset of ebuilds- worst case,
20 > .06% ebuilds. Personally, I don't consider that minority worth
21 > preserving since preserving that means leaving open several gotchas in
22 > ebuild writing, and complicates interactions (both pm and dev).
23 >
24 > So... there it is. Would be rather nice to have ebuild devs weight in
25 > on this one, rather then just package manager monkeys also (they're
26 > the ones bound most by the change after all). Laid out the advantages
27 > to this- kindly lay out the disadvantages, where this makes things
28 > worse if you're looking for a response.
29
30 I struggle to see the technical gain of banning -r0 while allowing _alpha0 and
31 002 which have the exact same technical issue. Forcing people to hard code
32 versions or use sucky substitutions such as ${PV/_alpha/_alpha0} or whatever
33 you'd use to convert cpufrequtils-2 to cpufrequtils-002 is clearly a loss of
34 feature.
35
36 I agree that explicit -r0 on disk isn't really useful given the current Gentoo
37 policy on revision bumps. But I think we established on bug #166522 [1] that
38 we don't want to make restrictions based on what is useful. Otherwise we
39 should ban _alpha_beta_pre_p too...
40
41 [1] https://bugs.gentoo.org/show_bug.cgi?id=166522
42
43 --
44 Bo Andresen
45 Gentoo KDE Dev

Attachments

File name MIME type
signature.asc application/pgp-signature