Gentoo Archives: gentoo-dev

From: Kristian Fiskerstrand <k_f@g.o>
To: gentoo-dev@l.g.o, "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-dev] [RFC pre-GLEP] Gentoo Git Workflow
Date: Thu, 27 Jul 2017 13:55:20
Message-Id: 769ccd85-a1a8-5d0c-e885-efaee9388a6d@gentoo.org
In Reply to: Re: [gentoo-dev] [RFC pre-GLEP] Gentoo Git Workflow by "Michał Górny"
1 On 07/27/2017 03:52 PM, Michał Górny wrote:
2 > On śro, 2017-07-26 at 19:17 +0200, Kristian Fiskerstrand wrote:
3 >> On 07/25/2017 10:05 AM, Michał Górny wrote:
4 >>> ** <kbd>Fixes: <nowiki>https://bugs.gentoo.org/NNNNNN</nowiki></kbd>;; —
5 >>> to indicate a fixed bug,
6 >>
7 >> At this point fixes is overloading
8 >>> ** <kbd>Fixes: commit-id (commit message)</kbd> — to indicate fixing a
9 >>> previous commit
10 >>
11 >> This use should be forbidden.
12 >
13 > ...because? But sure, you don't like it, let's remove it. Not that
14 > anyone will actually prefer the things from the GLEP over anything else.
15 >
16
17 Because it overloads the tag for multiple meanings and as such should be
18 different tags, we already have a tag that specifies the bug (namely
19 Bug, presuming we use Reference: for URL specification of relevant
20 upstream information or other discussions)
21
22 >>> ** <kbd>Bug: <nowiki>https://bugs.gentoo.org/NNNNNN</nowiki></kbd>;; — to
23 >>> reference a bug,
24 >>
25 >> See other comments in thread wrt Gentoo-Bug.
26 >>
27 >>> ** <kbd>Closes: <nowiki>https://github.com/gentoo/gentoo/pull/NNNN</nowi
28 >>> ki></kbd>; — to automatically close a GitHub pull request,
29 >>
30 >> Is this a generic tag for any pull request of any platform?
31 >
32 > No. As I've told multiple times already, there are *no* generic tags. It
33 > just happens to be used by some random platforms. Some others use e.g.
34 > 'Fixes' which you forbade.
35 >
36
37 Isn't that the point of having a GLEP to begin with? Trying to
38 standardize the use of e.g the tags so that it has a consistent meaning
39 and can be useful?
40
41 --
42 Kristian Fiskerstrand
43 OpenPGP keyblock reachable at hkp://pool.sks-keyservers.net
44 fpr:94CB AFDD 3034 5109 5618 35AA 0B7F 8B60 E3ED FAE3

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] [RFC pre-GLEP] Gentoo Git Workflow "Michał Górny" <mgorny@g.o>