| 1 |
On czw, 2017-07-27 at 15:54 +0200, Kristian Fiskerstrand wrote: |
| 2 |
> On 07/27/2017 03:52 PM, Michał Górny wrote: |
| 3 |
> > On śro, 2017-07-26 at 19:17 +0200, Kristian Fiskerstrand wrote: |
| 4 |
> > > On 07/25/2017 10:05 AM, Michał Górny wrote: |
| 5 |
> > > > ** <kbd>Fixes: <nowiki>https://bugs.gentoo.org/NNNNNN</nowiki></kbd>;;; — |
| 6 |
> > > > to indicate a fixed bug, |
| 7 |
> > > |
| 8 |
> > > At this point fixes is overloading |
| 9 |
> > > > ** <kbd>Fixes: commit-id (commit message)</kbd> — to indicate fixing a |
| 10 |
> > > > previous commit |
| 11 |
> > > |
| 12 |
> > > This use should be forbidden. |
| 13 |
> > |
| 14 |
> > ...because? But sure, you don't like it, let's remove it. Not that |
| 15 |
> > anyone will actually prefer the things from the GLEP over anything else. |
| 16 |
> > |
| 17 |
> |
| 18 |
> Because it overloads the tag for multiple meanings and as such should be |
| 19 |
> different tags, we already have a tag that specifies the bug (namely |
| 20 |
> Bug, presuming we use Reference: for URL specification of relevant |
| 21 |
> upstream information or other discussions) |
| 22 |
> |
| 23 |
> > > > ** <kbd>Bug: <nowiki>https://bugs.gentoo.org/NNNNNN</nowiki></kbd>;;; — to |
| 24 |
> > > > reference a bug, |
| 25 |
> > > |
| 26 |
> > > See other comments in thread wrt Gentoo-Bug. |
| 27 |
> > > |
| 28 |
> > > > ** <kbd>Closes: <nowiki>https://github.com/gentoo/gentoo/pull/NNNN</nowi |
| 29 |
> > > > ki></kbd>; — to automatically close a GitHub pull request, |
| 30 |
> > > |
| 31 |
> > > Is this a generic tag for any pull request of any platform? |
| 32 |
> > |
| 33 |
> > No. As I've told multiple times already, there are *no* generic tags. It |
| 34 |
> > just happens to be used by some random platforms. Some others use e.g. |
| 35 |
> > 'Fixes' which you forbade. |
| 36 |
> > |
| 37 |
> |
| 38 |
> Isn't that the point of having a GLEP to begin with? Trying to |
| 39 |
> standardize the use of e.g the tags so that it has a consistent meaning |
| 40 |
> and can be useful? |
| 41 |
> |
| 42 |
|
| 43 |
Tags are mentioned merely for convenience, and as examples. If you want |
| 44 |
to request GitHub support to add support for special Gentoo tags you've |
| 45 |
just invented, be my guest. But don't bother forwarding their reply to |
| 46 |
me because I know their answer. |
| 47 |
|
| 48 |
-- |
| 49 |
Best regards, |
| 50 |
Michał Górny |
Archives