| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA256 |
| 3 |
|
| 4 |
On 08/13/2015 12:43 PM, Robin H. Johnson wrote: |
| 5 |
> On Thu, Aug 13, 2015 at 10:36:16AM -0500, William Hubbs wrote: |
| 6 |
>> I understood the usefulness of this line to some when we were |
| 7 |
>> using CVS since it expanded into the ebuild revision, date, etc. |
| 8 |
>> |
| 9 |
>> This expansion doesn't take place under git, so now I don't |
| 10 |
>> understand the usefulness of this line. If I have missed |
| 11 |
>> something, can someone fill me in, or if it isn't useful any more |
| 12 |
>> can we consider removing it? |
| 13 |
> The following is the official answer of Infra, regarding the $Id$ |
| 14 |
> expansion. |
| 15 |
> |
| 16 |
> The intent is that the ONLY place the keywords are expanded, will |
| 17 |
> be in the rsync export. FUTURE tense, it's not ready yet. |
| 18 |
> |
| 19 |
> If there is demand (and I think the consensus is actually the |
| 20 |
> OPPOSITE), we could also have it expand on your local checkouts. |
| 21 |
> |
| 22 |
> It expands to the hash of the blob of that file; and from that, you |
| 23 |
> can identify which commits the blob exists in. |
| 24 |
> |
| 25 |
> The primary use case of it is to allow users to easily see what |
| 26 |
> version of a given ebuild they are using. |
| 27 |
> |
| 28 |
|
| 29 |
I honestly don't see the point of this when `git log` or even `git |
| 30 |
diff` or standard `diff` will tell you if what's in your overlay |
| 31 |
differs from the source. With some bash magic it could even be |
| 32 |
automated. The point of that 'feature' is to see what, if anything, |
| 33 |
has changed between one's overlay and Gentoo's running tree. A diff |
| 34 |
would not only be able to tell you *if* anything changed, but also |
| 35 |
*what*, without adding around 5-7 extra bytes per ebuild. Sure, it's |
| 36 |
only bytes, but when multiplied against the number of ebuilds we have, |
| 37 |
it can make a few hundred KB difference. When expanded, that number |
| 38 |
multiplies. Is it worth adding this extra bloat to something that a |
| 39 |
standard utility can expose better than a hash? |
| 40 |
|
| 41 |
Just my two cents. |
| 42 |
|
| 43 |
- -- |
| 44 |
Daniel Campbell - Gentoo Developer |
| 45 |
OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net |
| 46 |
fpr: AE03 9064 AE00 053C 270C 1DE4 6F7A 9091 1EA0 55D6 |
| 47 |
-----BEGIN PGP SIGNATURE----- |
| 48 |
Version: GnuPG v2 |
| 49 |
|
| 50 |
iQIcBAEBCAAGBQJVzbCnAAoJEAEkDpRQOeFwlvkP/1KVnAH09LmHlO7kFPdFhEvE |
| 51 |
IhoscaZc/Pve4QcLMwnWAq2T3Uq4EzqYW2hICyuOAvp6bvca1ybpv7U6k+FYws8V |
| 52 |
lSarmFidfd0LKRqwPzrEjZb6kVxkKefzsAyqAZK9JcU5AhkI6cjIjMRihbxSVAJv |
| 53 |
BphWmbZBVuU4ZmoRiUcGR0Qzhcd4D4K0qjk6R4r5yCKaU5ACXj+ul5FOiD4GmsKc |
| 54 |
288YgkLO8l+MQhLAQ5Ie6lL5E3tfVzgJ2U0F6R7xIG0uT8kXU5p7OuBN3ATEP96E |
| 55 |
P92T6QIOGug4fjjpdInjQPMaY+NnF3x6LshHgRQXHO1lWNIceJKTX+em4VqU4JEH |
| 56 |
UCsWgh+QPppPXrXTNE0J94BMK0DLP2iiHxYFtKT8u7ABfhAOvuTbA6B/H2ujjIaT |
| 57 |
919htZGbSt3JkLCo5/gxqrJbntmqG0hehYr25C/XTHXJ+c5B5reaWKwuYW1Smpg7 |
| 58 |
whVLUcEHVFiU32bMFiETKfNVIGa3mxNUfO9wHpqBD4lSUNr3eJao5R25t5NMDJkL |
| 59 |
/znRsFb5h49uZEASjBWTICIsKjfjqaydRS5oQ9VZZcxdo3azZboqxLeuEAUnSSrn |
| 60 |
H8/F6HNbSJ5MVetRG2DrLpWFCS94LSjhF4DYQk0xzK3lvMXHMrdhZI0G94ZTx9PW |
| 61 |
X2I5+Y9cj1mVLzWrxHyu |
| 62 |
=W4Zd |
| 63 |
-----END PGP SIGNATURE----- |
Archives