Gentoo Archives: gentoo-dev

From: William Hubbs <williamh@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] new eclass: golang-vcs-snapshot.eclass for golang vcs snapshots
Date: Wed, 05 Aug 2015 15:59:43
Message-Id: 20150805155931.GA1449@linux1.gaikai.biz
In Reply to: Re: [gentoo-dev] new eclass: golang-vcs-snapshot.eclass for golang vcs snapshots by William Hubbs
1 On Tue, Aug 04, 2015 at 02:19:52PM -0500, William Hubbs wrote:
2 > On Tue, Aug 04, 2015 at 12:17:50PM -0400, Mike Gilbert wrote:
3 > > The documentation says you are extracting to ${S}, but the function
4 > > actually extracts to ${WORKDIR}/${PN}.
5 >
6 > s/PN/P/
7 > > I would get rid of the useless "destdir" variable and replace all
8 > > usages with "${S}". Or update the docs.
9 >
10 > I got rid of the f and destdir variables and cleaned up the docs; here
11 > is the latest; let me know what you think.
12 >
13 > William
14 >
15
16 This version is now in the tree.
17
18 William

Attachments

File name MIME type
signature.asc application/pgp-signature