Gentoo Archives: gentoo-dev

From: William Hubbs <williamh@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] new eclass: golang-vcs-snapshot.eclass for golang vcs snapshots
Date: Tue, 04 Aug 2015 19:20:05
Message-Id: 20150804191952.GA9919@linux1.gaikai.biz
In Reply to: Re: [gentoo-dev] new eclass: golang-vcs-snapshot.eclass for golang vcs snapshots by Mike Gilbert
1 On Tue, Aug 04, 2015 at 12:17:50PM -0400, Mike Gilbert wrote:
2 > The documentation says you are extracting to ${S}, but the function
3 > actually extracts to ${WORKDIR}/${PN}.
4
5 s/PN/P/
6 > I would get rid of the useless "destdir" variable and replace all
7 > usages with "${S}". Or update the docs.
8
9 I got rid of the f and destdir variables and cleaned up the docs; here
10 is the latest; let me know what you think.
11
12 William

Attachments

File name MIME type
golang-vcs-snapshot.eclass text/plain
signature.asc application/pgp-signature

Replies