Gentoo Archives: gentoo-dev

From: "Marty E. Plummer" <hanetzer@×××××××××.com>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] eclass/java-utils-2: switch to eapi7-ver
Date: Sat, 23 Feb 2019 02:52:33
Message-Id: 20190223025111.6iokyq2z3gjhhroy@proprietary-killer
In Reply to: Re: [gentoo-dev] [PATCH] eclass/java-utils-2: switch to eapi7-ver by Andreas Sturmlechner
1 On Thu, Feb 21, 2019 at 03:30:32PM +0100, Andreas Sturmlechner wrote:
2 > On Montag, 17. Dezember 2018 09:09:13 CET Marty E. Plummer wrote:
3 > > @@ -15,7 +15,7 @@
4 > > # you should inherit java-pkg-2 for Java packages or java-pkg-opt-2 for
5 > > packages # that have optional Java support. In addition you can inherit
6 > > java-ant-2 for # Ant-based packages.
7 > > -inherit eutils versionator multilib
8 > > +inherit eutils multilib
9 >
10 > I would recommend to keep inheriting all those eclasses (including
11 > versionator) for EAPI 0-6, in order not to break revdeps with implicit use.
12 > Who knows in what shape they are, and no one is going to fix them for a long
13 > time. But we don't want to inherit any of them with EAPI-7, hence merge it
14 > with below hunk.
15 >
16 Yeah, I came to the same conclusion when I suggested a move from
17 versionator to eapi7-ver for gnome.org.eclass and it had implicit deps
18 on versionator in its consumers.
19 > > @@ -25,6 +25,9 @@ export WANT_JAVA_CONFIG="2"
20 > > # Prefix variables are only available for EAPI>=3
21 > > has "${EAPI:-0}" 0 1 2 && ED="${D}" EPREFIX= EROOT="${ROOT}"
22 > >
23 > > +# EAPI 7 has version functions built-in. Use eapi7-ver for all earlier
24 > > eclasses.
25 > > +[[ ${EAPI} == [0123456] ]] && inherit eapi7-ver
26 > > +
27 > > # @VARIABLE: JAVA_PKG_E_DEPEND
28 > > # @INTERNAL
29 > > # @DESCRIPTION:
30 >
31 >
32 > Regards,
33 > Andreas
34 >
35 >
36 >