Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: David Seifert <soap@g.o>
Cc: gentoo-dev@l.g.o, python@g.o
Subject: Re: [gentoo-dev] [PATCH 1/3] python-any-r1.eclass: Constrain to EAPI >= 5
Date: Sat, 14 Dec 2019 11:29:41
Message-Id: w6gy2vftaav.fsf@kph.uni-mainz.de
In Reply to: [gentoo-dev] [PATCH 1/3] python-any-r1.eclass: Constrain to EAPI >= 5 by David Seifert
1 >>>>> On Sat, 14 Dec 2019, David Seifert wrote:
2
3 > case "${EAPI:-0}" in
4 > - 0|1|2|3|4|5|6|7)
5 > + [01234])
6 > + die "Unsupported EAPI=${EAPI:-0} (too old) for ${ECLASS}"
7 > + ;;
8 > + [567])
9 > ;;
10 > *)
11 > die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"
12
13 I know that this exists in other eclasses as well, but do we really need
14 that distinction in the error message for "too old" and "unknown" EAPIs?
15 It should be pretty clear which case applies there, especially since the
16 message is addressed at developers, not users.
17
18 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies