| 1 |
On Mon, Feb 23, 2009 at 08:45:28PM +0100, Christian Faulhammer wrote: |
| 2 |
> > if [[ ${EBZR_REPO_URI} == */* ]]; then |
| 3 |
> > repository="${EBZR_REPO_URI}/${EBZR_BRANCH}" |
| 4 |
> > elif [[ -n ${EBZR_BRANCH} ]] ; then |
| 5 |
> > ... |
| 6 |
> > else |
| 7 |
> > ... |
| 8 |
> > fi |
| 9 |
> > |
| 10 |
> > If I see this correctly, this appends EBZR_BRANCH if there is a slash |
| 11 |
> > in the REPO_URI ... what kind of guess is this supposed to be? I |
| 12 |
> > think, the second test (append iff EBZR_BRANCH is set) should be |
| 13 |
> > sufficient. |
| 14 |
> |
| 15 |
> Not sure, though I will investigate (and likely drop it). |
| 16 |
|
| 17 |
Kindly drop that; the REPO_URI/BRANCH seperation that is in use there |
| 18 |
really isn't all that useful for bzr ebuilds in my experience- more |
| 19 |
often then not it winds up biting me in the ass rather then being |
| 20 |
useful. |
| 21 |
|
| 22 |
My usage (and understanding of bzr), there isn't a scenario where |
| 23 |
seperation of the repo and branch applies- you only need the branch |
| 24 |
uri, that encompasses it all (unlike cvs, where this probably was |
| 25 |
inherited from). |
| 26 |
|
| 27 |
So... any reason to even have the var seperation like that? |
| 28 |
|
| 29 |
~harring |
Archives