Gentoo Archives: gentoo-dev

From: Christian Faulhammer <fauli@g.o>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] Re: bzr.eclass
Date: Mon, 23 Feb 2009 19:45:55
Message-Id: 20090223204528.636b5be9@terra.solaris
In Reply to: Re: [gentoo-dev] bzr.eclass by "René 'Necoro' Neumann"
1 Hi,
2
3 René 'Necoro' Neumann <lists@××××××.eu>:
4
5 > -----BEGIN PGP SIGNED MESSAGE-----
6 > Hash: SHA1
7 >
8 > Jorge Manuel B. S. Vicetto schrieb:
9 > > Hi.
10 > >
11 > > Christian Faulhammer wrote:
12 > >> Hi,
13 > >>
14 > >> a user maintained a Bazaar overlay for some time now and introduced
15 > >> some changes to bzr eclass, I would like to introduce into the
16 > >> tree. Please review the attached patch.
17 > >>
18 > >> V-Li
19 > >
20 > > I'm attaching a revised patch that tries to improve some issues in
21 > > the current version in the tree, incorporates your changes and Peter
22 > > Volkov's (pva) patch about sftp URIs.
23 > >
24 > >
25 >
26 > if [[ ${EBZR_REPO_URI} == */* ]]; then
27 > repository="${EBZR_REPO_URI}/${EBZR_BRANCH}"
28 > elif [[ -n ${EBZR_BRANCH} ]] ; then
29 > ...
30 > else
31 > ...
32 > fi
33 >
34 > If I see this correctly, this appends EBZR_BRANCH if there is a slash
35 > in the REPO_URI ... what kind of guess is this supposed to be? I
36 > think, the second test (append iff EBZR_BRANCH is set) should be
37 > sufficient.
38
39 Not sure, though I will investigate (and likely drop it).
40
41 V-Li
42
43 --
44 Christian Faulhammer, Gentoo Lisp project
45 <URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
46
47 <URL:http://www.faulhammer.org/>

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] Re: bzr.eclass Brian Harring <ferringb@×××××.com>