Gentoo Archives: gentoo-dev

From: "René 'Necoro' Neumann" <lists@××××××.eu>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] bzr.eclass
Date: Fri, 20 Feb 2009 12:30:58
Message-Id: 499EA27D.5060608@necoro.eu
In Reply to: Re: [gentoo-dev] bzr.eclass by "Jorge Manuel B. S. Vicetto"
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 Jorge Manuel B. S. Vicetto schrieb:
5 > Hi.
6 >
7 > Christian Faulhammer wrote:
8 >> Hi,
9 >>
10 >> a user maintained a Bazaar overlay for some time now and introduced
11 >> some changes to bzr eclass, I would like to introduce into the tree.
12 >> Please review the attached patch.
13 >>
14 >> V-Li
15 >
16 > I'm attaching a revised patch that tries to improve some issues in the
17 > current version in the tree, incorporates your changes and Peter
18 > Volkov's (pva) patch about sftp URIs.
19 >
20 >
21
22 if [[ ${EBZR_REPO_URI} == */* ]]; then
23 repository="${EBZR_REPO_URI}/${EBZR_BRANCH}"
24 elif [[ -n ${EBZR_BRANCH} ]] ; then
25 ...
26 else
27 ...
28 fi
29
30 If I see this correctly, this appends EBZR_BRANCH if there is a slash in
31 the REPO_URI ... what kind of guess is this supposed to be? I think, the
32 second test (append iff EBZR_BRANCH is set) should be sufficient.
33
34 Regards,
35 Necoro
36 -----BEGIN PGP SIGNATURE-----
37 Version: GnuPG v2.0.9 (GNU/Linux)
38 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
39
40 iEYEARECAAYFAkmeon0ACgkQ4UOg/zhYFuCf7gCfWSyBZrzct0jvUl9W+yml52+K
41 7ToAmwRry/H/3ZlH0bjNNg82f+gIIzBZ
42 =cqx5
43 -----END PGP SIGNATURE-----

Replies

Subject Author
[gentoo-dev] Re: bzr.eclass Christian Faulhammer <fauli@g.o>