1 |
On 23:45 Sat 13 Oct , Drake Wyrm wrote: |
2 |
> Donnie Berkholz <dberkholz@g.o> wrote: |
3 |
> > On 13:36 Sat 13 Oct , Matti Bickel (mabi) wrote: |
4 |
> > > if kernel_is gt 2 6 20 ; then |
5 |
> > > epatch "${FILESDIR}"/${PV}-register_sysctl_table.patch |
6 |
> > > fi |
7 |
> > > |
8 |
> > > if kernel_is ge 2 6 22 ; then |
9 |
> > > epatch "${FILESDIR}"/${PV}-kmem-and-dtor-fix.patch |
10 |
> > > fi |
11 |
> > |
12 |
> > Mixing 'gt' and 'ge' is a bad idea. |
13 |
> |
14 |
> Just outa curiosity, why? |
15 |
|
16 |
Because it's inconsistent and one generally assumes that people will be |
17 |
consistent with the way they test numbers. That way you only need to |
18 |
read the number rather than continually checking every single line to |
19 |
see how exactly it's tested for. |
20 |
|
21 |
Thanks, |
22 |
Donnie |
23 |
-- |
24 |
gentoo-dev@g.o mailing list |