| 1 |
Donnie Berkholz wrote: |
| 2 |
> On 23:45 Sat 13 Oct , Drake Wyrm wrote: |
| 3 |
>> Donnie Berkholz <dberkholz@g.o> wrote: |
| 4 |
>> > On 13:36 Sat 13 Oct , Matti Bickel (mabi) wrote: |
| 5 |
>> > > if kernel_is gt 2 6 20 ; then |
| 6 |
>> > > epatch "${FILESDIR}"/${PV}-register_sysctl_table.patch |
| 7 |
>> > > fi |
| 8 |
>> > > |
| 9 |
>> > > if kernel_is ge 2 6 22 ; then |
| 10 |
>> > > epatch "${FILESDIR}"/${PV}-kmem-and-dtor-fix.patch |
| 11 |
>> > > fi |
| 12 |
>> > |
| 13 |
>> > Mixing 'gt' and 'ge' is a bad idea. |
| 14 |
>> |
| 15 |
>> Just outa curiosity, why? |
| 16 |
> |
| 17 |
> Because it's inconsistent and one generally assumes that people will be |
| 18 |
> consistent with the way they test numbers. That way you only need to |
| 19 |
> read the number rather than continually checking every single line to |
| 20 |
> see how exactly it's tested for. |
| 21 |
> |
| 22 |
I don't see how this is inconsistent either: two tests are needed, so that |
| 23 |
both patches are only applied for >=2.6.22 and first only if >2.6.20. |
| 24 |
|
| 25 |
(If the eclass performs inconsistently, that would need to be fixed.) |
| 26 |
|
| 27 |
|
| 28 |
-- |
| 29 |
gentoo-dev@g.o mailing list |
Archives