| 1 |
Steve Long <slong@××××××××××××××××××.uk> wrote: |
| 2 |
> >> > Mixing 'gt' and 'ge' is a bad idea. |
| 3 |
> >> |
| 4 |
> >> Just outa curiosity, why? |
| 5 |
> > |
| 6 |
> > Because it's inconsistent and one generally assumes that people will be |
| 7 |
> > consistent with the way they test numbers. That way you only need to |
| 8 |
> > read the number rather than continually checking every single line to |
| 9 |
> > see how exactly it's tested for. |
| 10 |
> > |
| 11 |
> I don't see how this is inconsistent either: two tests are needed, so that |
| 12 |
> both patches are only applied for >=2.6.22 and first only if >2.6.20. |
| 13 |
|
| 14 |
The point is that if you stick to "ge" OR "gt", everyone could just skip |
| 15 |
reading the comparison and focus on the numbers. Will be fixed in the |
| 16 |
next release, along with kernel-2.4 support... |
| 17 |
|
| 18 |
-- |
| 19 |
Regards, Matti Bickel |
| 20 |
Signed/Encrypted email preferred (key 4849EC6C) |
Archives