1 |
On Sat, Nov 17, 2012 at 11:06:38PM -0500, Richard Yao wrote: |
2 |
> On 11/17/2012 10:39 PM, Greg KH wrote: |
3 |
> > Anyway, I now see a _very_ dangerous commit in the "Copyright" branch |
4 |
> > that better not get merged into the tree, as it's wrong, and illegal |
5 |
> > under all countries that follow the "normal" body of Copyright Law. It |
6 |
> > should be removed right now before someone gets into trouble, not the |
7 |
> > least of which would be the orginization that the copyright is now being |
8 |
> > attributed to. |
9 |
> > |
10 |
> > Come on people, this is basic copyright law, it's not something |
11 |
> > radically new. It's something that _all_ software developers should |
12 |
> > know, either from school, or any company they have ever worked at. |
13 |
> > |
14 |
> > Please fix this now. |
15 |
> klondike discussed the copyright branch changes with robbat2 before they |
16 |
> started and there was no problem at the time. We have retained all |
17 |
> copyright notices and looking at the branch, I find nothing objectionable. |
18 |
To note here, since I was CC'd directly: |
19 |
I said changed files should get the modified notice, as Gentoo should have |
20 |
copyright on the changes that are explicitly new by Gentoo. I didn't say to add |
21 |
it to every file in the repo (but I will admit that I didn't tell him not to |
22 |
either). |
23 |
|
24 |
I'll state it clearly what should be the case: |
25 |
- the s/systemd/eudev/ line, and insertion of "From prior code in systemd and |
26 |
pre-systemd udev" being added now is fine. |
27 |
- WHEN substantial changes are made to an existing file, the copyright |
28 |
attribution should be amended to include the Gentoo Foundation. The |
29 |
attribution should NOT be changed before this. Better text given the existing |
30 |
wording would be: |
31 |
Portions Copyright 2012 Gentoo Foundation. |
32 |
|
33 |
- Files that have no copyright notice should NOT be touched until such time as |
34 |
a major addition is added to them. |
35 |
|
36 |
http://dpaste.com/832634/ is what I approved with klondike (his 2nd paste to me |
37 |
in the discussion). |
38 |
|
39 |
Copying out of the pastebin so we have a permanent record. |
40 |
> Original: |
41 |
> /*** |
42 |
> This file is part of systemd. |
43 |
> |
44 |
> Copyright 2011 Lennart Poettering |
45 |
> |
46 |
> systemd is free software; you can redistribute it and/or modify it |
47 |
> under the terms of the GNU Lesser General Public License as published by |
48 |
> the Free Software Foundation; either version 2.1 of the License, or |
49 |
> (at your option) any later version. |
50 |
> |
51 |
> systemd is distributed in the hope that it will be useful, but |
52 |
> WITHOUT ANY WARRANTY; without even the implied warranty of |
53 |
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU |
54 |
> Lesser General Public License for more details. |
55 |
> |
56 |
> You should have received a copy of the GNU Lesser General Public License |
57 |
> along with systemd; If not, see <http://www.gnu.org/licenses/>. |
58 |
> ***/ |
59 |
> |
60 |
> Modification: |
61 |
> |
62 |
> /*** |
63 |
> This file is part of eudev. |
64 |
> From prior code in systemd and pre-systemd udev. |
65 |
> |
66 |
> Copyright 2011 Lennart Poettering |
67 |
> Copyright 2012 Gentoo Foundation |
68 |
> |
69 |
> eudev is free software; you can redistribute it and/or modify it |
70 |
> under the terms of the GNU Lesser General Public License as published by |
71 |
> the Free Software Foundation; either version 2.1 of the License, or |
72 |
> (at your option) any later version. |
73 |
> |
74 |
> eudev is distributed in the hope that it will be useful, but |
75 |
> WITHOUT ANY WARRANTY; without even the implied warranty of |
76 |
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU |
77 |
> Lesser General Public License for more details. |
78 |
> |
79 |
> You should have received a copy of the GNU Lesser General Public License |
80 |
> along with eudev; If not, see <http://www.gnu.org/licenses/>. |
81 |
> ***/ |
82 |
|
83 |
|
84 |
|
85 |
|
86 |
-- |
87 |
Robin Hugh Johnson |
88 |
Gentoo Linux: Developer, Trustee & Infrastructure Lead |
89 |
E-Mail : robbat2@g.o |
90 |
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 |