| 1 |
On 2019-08-03 18:20, Ulrich Mueller wrote: |
| 2 |
>>>>>> On Sat, 03 Aug 2019, Thomas Deutschmann wrote: |
| 3 |
> |
| 4 |
>> +# @ECLASS-VARIABLE: _SAVEDCONFIG_CONFIGURATION_FILE |
| 5 |
> |
| 6 |
> 31 chars? Seems excessive for a name of a private variable. |
| 7 |
|
| 8 |
And? I'll keep that name for readability instead of finding an |
| 9 |
abbreviation. |
| 10 |
|
| 11 |
|
| 12 |
>> +# Restores the configuration saved ebuild previously potentially with user edits. |
| 13 |
> |
| 14 |
> If have trouble understanding this sentence. |
| 15 |
|
| 16 |
v2 will contain a better sentence. |
| 17 |
|
| 18 |
|
| 19 |
>> + if [[ -r "${configfile}" ]] ; then |
| 20 |
> |
| 21 |
> Quotes are not necessary here. |
| 22 |
|
| 23 |
Not necessary but it won't hurt. I'd like to keep them for style. I.e. I |
| 24 |
think it's better to always quote so you won't forget when it will |
| 25 |
become critical. |
| 26 |
|
| 27 |
|
| 28 |
-- |
| 29 |
Regards, |
| 30 |
Thomas Deutschmann / Gentoo Linux Developer |
| 31 |
C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5 |
Archives