Re: [gentoo-dev] [PATCH] multilib eclass support for building binaries for none-default ABI

[Ulrich Mueller]

>>>>> On Sun, 25 Aug 2013, Thomas Sachau wrote:

> workaround: add a variable, which changes the return of the function
> checking for the current ABI (always true with variable, without
> only true, when $ABI == $DEFAULT_ABI)

Would this variable be set by the user, in profiles, or in ebuilds?

> first version (multilib1.patch) directly changes the output of the
> currently used multilib_is_native_abi() function:

I think this would be very misleading. If a function is called
multilib_is_native_abi then it should test for exactly that, not for
something else.

> second version (multilib2.patch) creates a new function, which
> should then be used by ebuild authors to check, if they should build
> ABI-specific content or not (using build_binaries() function instead
> of multilib_is_native_abi() function)

+build_binaries() {

Name space pollution? Prefix with "multilib" please.

+	if [[ ${COMPLETE_MULTILIB} == yes ]] ; then
+		return 0
+	else
+		multilib_is_native_abi
+	fi

This can be expressed much shorter (and clearer):

	[[ ${COMPLETE_MULTILIB} == yes ]] || multilib_is_native_abi

But allow me a stupid question, why do you want to build binaries for
other ABIs anyway? It's called multilib, not multibin.

Ulrich