Re: [gentoo-dev] [PATCH] multilib eclass support for building binaries for none-default ABI

[Thomas Sachau]

Ulrich Mueller schrieb:
>>>>>> On Sun, 25 Aug 2013, Thomas Sachau wrote:
>
>> workaround: add a variable, which changes the return of the function
>> checking for the current ABI (always true with variable, without
>> only true, when $ABI == $DEFAULT_ABI)
>
> Would this variable be set by the user, in profiles, or in ebuilds?

This variable can be set by users and profiles, when they want binaries
for a different ABI (e.g. 64bit toolchain with 32bit userland).

>
>> first version (multilib1.patch) directly changes the output of the
>> currently used multilib_is_native_abi() function:
>
> I think this would be very misleading. If a function is called
> multilib_is_native_abi then it should test for exactly that, not for
> something else.
>
>> second version (multilib2.patch) creates a new function, which
>> should then be used by ebuild authors to check, if they should build
>> ABI-specific content or not (using build_binaries() function instead
>> of multilib_is_native_abi() function)
>
> +build_binaries() {
>
> Name space pollution? Prefix with "multilib" please.

i dont really care about the naming, so if you prefer some multilib in
there, how about this:

multilib_build_binaries()?

>
> +	if [[ ${COMPLETE_MULTILIB} == yes ]] ; then
> +		return 0
> +	else
> +		multilib_is_native_abi
> +	fi
>
> This can be expressed much shorter (and clearer):
>
> 	[[ ${COMPLETE_MULTILIB} == yes ]] || multilib_is_native_abi
>
> But allow me a stupid question, why do you want to build binaries for
> other ABIs anyway? It's called multilib, not multibin.

I already wrote about a setup needing the above. If a user only enables
ab_x86_32 for ebuilds with binary-restrictions, they wont get any binary
at all.
Pretty bad, when you try a reboot with e.g. no udev binaries. ;-)

In addition, users previously had the choice with multilib-portage to
build binaries for some or all target ABIs. Restricting the building of
binaries to the default ABI removes this ability from users.


-- 

Thomas Sachau
Gentoo Linux Developer