1 |
2010-07-05 23:49:58 Samuli Suominen napisał(a): |
2 |
> On 07/06/2010 12:38 AM, Arfrever Frehtes Taifersar Arahesis wrote: |
3 |
> > 2010-07-05 23:28:01 Samuli Suominen napisał(a): |
4 |
> >> On 07/05/2010 11:23 PM, Arfrever Frehtes Taifersar Arahesis wrote: |
5 |
> >>> 2010-07-05 21:18:57 Mark Loeser napisał(a): |
6 |
> >>>> Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o> said: |
7 |
> >>>>> 2010-07-05 20:00:11 Mark Loeser napisał(a): |
8 |
> >>>>>> Everyone else has already made valid points. I'm just picking this one |
9 |
> >>>>>> to reply to now. Please remove the colors you have added. If you need |
10 |
> >>>>>> a new function, say "eqawarn", we should have that added in the next |
11 |
> >>>>>> EAPI with a description of when and where to use it. |
12 |
> >>>>> |
13 |
> >>>>> In case of the colored message added in this patch, if einfo/elog/ewarn/eqawarn/eerror was used, |
14 |
> >>>>> then its output wouldn't be logged by Portage. |
15 |
> >>>> |
16 |
> >>>> I don't understand what you are trying to say. |
17 |
> >>> |
18 |
> >>> Portage doesn't log output of einfo/elog/ewarn/eqawarn/eerror called in global scope. |
19 |
> >> |
20 |
> >> Can you point to the location of python.eclass / distutils.eclass where |
21 |
> >> you need to send output from global scope, please? |
22 |
> > |
23 |
> > It's at the beginning of this patch. NEED_PYTHON is parsed in global scope. |
24 |
> > |
25 |
> |
26 |
> OK, so let me get this right... are trying to justify using all of the |
27 |
> echo+custom colorization in the eclass by this one occurance, in basis |
28 |
> of it doesn't get logged otherwise? |
29 |
|
30 |
I was justifying using colors in this case (NEED_PYTHON). I'm completely against not using colors |
31 |
in status messages (e.g. "Building of dev-python/setuptools-0.6.13 with CPython 3.1..."), which |
32 |
are more useful, when they are easily noticeable by ebuild maintainers. I might agree to remove |
33 |
colors in other deprecation warnings, but this patch wasn't adding any other deprecation warnings. |
34 |
Not using colors in deprecation warnings doesn't have any benefits and only decreases noticeability |
35 |
of deprecation warnings. |
36 |
|
37 |
-- |
38 |
Arfrever Frehtes Taifersar Arahesis |