| 1 |
On Fri, 06 Dec 2019 16:35:53 +0100 |
| 2 |
Ulrich Müller <ulm@g.o> wrote: |
| 3 |
|
| 4 |
> # The user wants us to leave things be. |
| 5 |
> - if [[ -n ${DONT_MOUNT_BOOT} ]] ; then |
| 6 |
> + if [[ -n ${I_KNOW_WHAT_I_AM_DOING} ]] ; then |
| 7 |
> return 0 |
| 8 |
> fi |
| 9 |
|
| 10 |
The rest of patch looks ok but I find I_KNOW_WHAT_I_AM_DOING |
| 11 |
proliferation worrying. Having enough eclasses guard things on it I don't |
| 12 |
really know what I am doing :) |
| 13 |
|
| 14 |
For example developer profile sets it on by default and disables perl error |
| 15 |
checks. I don't think it's intentional. |
| 16 |
|
| 17 |
I suggest giving this variable a unique specific name. And phase out |
| 18 |
${I_KNOW_WHAT_I_AM_DOING} uses from tree completely. |
| 19 |
|
| 20 |
-- |
| 21 |
|
| 22 |
Sergei |
Archives