| 1 |
>>>>> On Sat, 07 Dec 2019, Sergei Trofimovich wrote: |
| 2 |
|
| 3 |
>> # The user wants us to leave things be. |
| 4 |
>> - if [[ -n ${DONT_MOUNT_BOOT} ]] ; then |
| 5 |
>> + if [[ -n ${I_KNOW_WHAT_I_AM_DOING} ]] ; then |
| 6 |
>> return 0 |
| 7 |
>> fi |
| 8 |
|
| 9 |
> The rest of patch looks ok but I find I_KNOW_WHAT_I_AM_DOING |
| 10 |
> proliferation worrying. Having enough eclasses guard things on it I |
| 11 |
> don't really know what I am doing :) |
| 12 |
|
| 13 |
> For example developer profile sets it on by default and disables perl |
| 14 |
> error checks. I don't think it's intentional. |
| 15 |
|
| 16 |
Oh, I forgot that it is set globally in the developer profile (and I |
| 17 |
think that's a stupid idea). Indeed we should use a different variable |
| 18 |
then. |
| 19 |
|
| 20 |
> I suggest giving this variable a unique specific name. |
| 21 |
|
| 22 |
Would it be acceptable to leave DONT_MOUNT_BOOT in place? It would have |
| 23 |
the advantage that users won't have to update their config. |
| 24 |
|
| 25 |
> And phase out ${I_KNOW_WHAT_I_AM_DOING} uses from tree completely. |
| 26 |
|
| 27 |
That's a separate discussion. |
| 28 |
|
| 29 |
Ulrich |
Archives