| 1 |
On Sat, 07 Dec 2019 06:44:21 +0100 |
| 2 |
Ulrich Mueller <ulm@g.o> wrote: |
| 3 |
|
| 4 |
> >>>>> On Sat, 07 Dec 2019, Sergei Trofimovich wrote: |
| 5 |
> |
| 6 |
> >> # The user wants us to leave things be. |
| 7 |
> >> - if [[ -n ${DONT_MOUNT_BOOT} ]] ; then |
| 8 |
> >> + if [[ -n ${I_KNOW_WHAT_I_AM_DOING} ]] ; then |
| 9 |
> >> return 0 |
| 10 |
> >> fi |
| 11 |
> |
| 12 |
> > The rest of patch looks ok but I find I_KNOW_WHAT_I_AM_DOING |
| 13 |
> > proliferation worrying. Having enough eclasses guard things on it I |
| 14 |
> > don't really know what I am doing :) |
| 15 |
> |
| 16 |
> > For example developer profile sets it on by default and disables perl |
| 17 |
> > error checks. I don't think it's intentional. |
| 18 |
> |
| 19 |
> Oh, I forgot that it is set globally in the developer profile (and I |
| 20 |
> think that's a stupid idea). Indeed we should use a different variable |
| 21 |
> then. |
| 22 |
> |
| 23 |
> > I suggest giving this variable a unique specific name. |
| 24 |
> |
| 25 |
> Would it be acceptable to leave DONT_MOUNT_BOOT in place? It would have |
| 26 |
> the advantage that users won't have to update their config. |
| 27 |
|
| 28 |
Sounds good. |
| 29 |
|
| 30 |
> > And phase out ${I_KNOW_WHAT_I_AM_DOING} uses from tree completely. |
| 31 |
> |
| 32 |
> That's a separate discussion. |
| 33 |
|
| 34 |
Sure. As long as we don't add extra uses. |
| 35 |
|
| 36 |
|
| 37 |
-- |
| 38 |
|
| 39 |
Sergei |
Archives