Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-admin/chrpath: ChangeLog chrpath-0.13-r2.ebuild

[Samuli Suominen]

On 10/11/2011 09:13 PM, Fabian Groffen wrote:
> On 11-10-2011 21:01:40 +0300, Samuli Suominen wrote:
>> On 10/11/2011 08:05 PM, Fabian Groffen wrote:
>>> On 11-10-2011 19:59:13 +0300, Samuli Suominen wrote:
>>>> So I've missed one ${EPREFIX} for docdir= ? How about just fixing that,
>>>> and not crapping all over the package?
>>>
>>> How about first asking the maintainer before you completely rewrite an
>>> ebuild?  I'm not innocent on this topic either (ask Diego for example),
>>> and I do allow you to make a lot of changes to my packages.  Just don't
>>> force your style and preferences on me.
>>
>> So basically you are saying you reverted tehnically correct changes for
>> cosmetics. What ticked you off, the \ lines changes? I believe that was
>> the only change that wasn't about fixing something broken.
>
> No, you broke the package for Prefix.  Next you bumped it to EAPI=4,
> then you removed SRC_URI for no particular reason, dropped libtool files
> and dropped static archives.  Next to this you did some reordering and
> other cosmetic changes.
>
>> And so have you, changed dozens of my ebuilds for PREFIX compability or
>> other random fixes, not everything turned out correct, mistakes were
>> made and were clearly accidental. I've fixed them instead of wasting
>> both of our times. Is it too much to ask for same in return?
>
> I already told you that you can change quite a lot to my ebuilds,
> without me complaining.  Do you mind me reverting your stuff and redoing
> it now?
>
>

Thanks, the end result of installed files look now OK. Care to reopen
the stabilization bug? The changes are trivial.

I just hope nobody will take an example of the ebuild with code
duplication (multiple epatch calls), overquoting, redudant use of find
when rm is more than enough, ...