1 |
On 07/18/2013 12:06 AM, Michał Górny wrote: |
2 |
> Dnia 2013-07-17, o godz. 17:42:32 |
3 |
> "Rick \"Zero_Chaos\" Farina" <zerochaos@g.o> napisał(a): |
4 |
> |
5 |
>> -----BEGIN PGP SIGNED MESSAGE----- |
6 |
>> Hash: SHA1 |
7 |
> |
8 |
>> On 07/17/2013 05:34 PM, hasufell wrote: |
9 |
>>> On 07/17/2013 11:28 PM, Rick "Zero_Chaos" Farina wrote: |
10 |
>>>> ...and that is why it isn't permitted to directly use an eclass |
11 |
>>>> that you don't inherit. While I agree testing could (should) have |
12 |
>>>> been better, the fact that people ignore the rules for writing |
13 |
>>>> ebuilds shouldn't entirely fall on the KDE team. |
14 |
>>> |
15 |
>>> |
16 |
>>> It doesn't matter in the slightest whos fault it is or who should be |
17 |
>>> blamed. |
18 |
>>> |
19 |
>>> It is about maintaining stability for the user. Especially when it |
20 |
>>> comes to stable ebuilds. |
21 |
>>> |
22 |
>>> That means the methods for eclass changes must be more thoroughly. |
23 |
> |
24 |
>> I completely agree with you, the changes should have been tested better. |
25 |
>> The ebuilds with these errors popping up ALSO should have been tested |
26 |
>> better. Considering this is a QA violation, perhaps it is possible to |
27 |
>> add a check in repoman for using something from an eclass which you |
28 |
>> didn't inherit. I doubt the slowdown would be horrible and clearly it |
29 |
>> would catch a huge number of QA violations. |
30 |
> |
31 |
> Repoman has such check already. It pops up for specific functions |
32 |
> listed in repoman source code. This allows us to catch the common |
33 |
> mistakes while avoiding false positives. |
34 |
> |
35 |
> Maybe it should always pop up for phase functions. I don't immediately |
36 |
> see a reason why an ebuild would use a phase function of an eclass it |
37 |
> doesn't inherit directly. |
38 |
|
39 |
That check is only enabled in portage-2.2, because I really want it to |
40 |
parse the relevant info directly from the eclasses. That way, we won't |
41 |
have to update repoman for eclass changes. |
42 |
-- |
43 |
Thanks, |
44 |
Zac |