| 1 |
-----BEGIN PGP SIGNED MESSAGE-----
|
| 2 |
Hash: SHA512
|
| 3 |
|
| 4 |
Dnia 2013-07-17, o godz. 17:42:32
|
| 5 |
"Rick \"Zero_Chaos\" Farina" <zerochaos@g.o> napisał(a):
|
| 6 |
|
| 7 |
> -----BEGIN PGP SIGNED MESSAGE----- |
| 8 |
> Hash: SHA1 |
| 9 |
> |
| 10 |
> On 07/17/2013 05:34 PM, hasufell wrote: |
| 11 |
> > On 07/17/2013 11:28 PM, Rick "Zero_Chaos" Farina wrote: |
| 12 |
> >> ...and that is why it isn't permitted to directly use an eclass |
| 13 |
> >> that you don't inherit. While I agree testing could (should) have |
| 14 |
> >> been better, the fact that people ignore the rules for writing |
| 15 |
> >> ebuilds shouldn't entirely fall on the KDE team. |
| 16 |
> > |
| 17 |
> > |
| 18 |
> > It doesn't matter in the slightest whos fault it is or who should be |
| 19 |
> > blamed. |
| 20 |
> > |
| 21 |
> > It is about maintaining stability for the user. Especially when it |
| 22 |
> > comes to stable ebuilds. |
| 23 |
> > |
| 24 |
> > That means the methods for eclass changes must be more thoroughly. |
| 25 |
> |
| 26 |
> I completely agree with you, the changes should have been tested better. |
| 27 |
> The ebuilds with these errors popping up ALSO should have been tested |
| 28 |
> better. Considering this is a QA violation, perhaps it is possible to |
| 29 |
> add a check in repoman for using something from an eclass which you |
| 30 |
> didn't inherit. I doubt the slowdown would be horrible and clearly it |
| 31 |
> would catch a huge number of QA violations. |
| 32 |
|
| 33 |
Repoman has such check already. It pops up for specific functions
|
| 34 |
listed in repoman source code. This allows us to catch the common
|
| 35 |
mistakes while avoiding false positives.
|
| 36 |
|
| 37 |
Maybe it should always pop up for phase functions. I don't immediately
|
| 38 |
see a reason why an ebuild would use a phase function of an eclass it
|
| 39 |
doesn't inherit directly.
|
| 40 |
|
| 41 |
- --
|
| 42 |
Best regards,
|
| 43 |
Michał Górny
|
| 44 |
-----BEGIN PGP SIGNATURE-----
|
| 45 |
Version: GnuPG v2.0.20 (GNU/Linux)
|
| 46 |
|
| 47 |
iQJ8BAEBCgBmBQJR55QGXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
|
| 48 |
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ1RUJGMjBGOTk2RkIzQzIyQ0M2RkNBNDBC
|
| 49 |
QUJGMUQ1RkY4QzgxMTBBAAoJELq/HV/4yBEKHMcQAIwiDjgyegvvuHl9dzSlRK9S
|
| 50 |
uTZH/kSBrIRppXIDWqC48Cj1LrRGVZoWIbHE9xd4qd0Hb37jva07JmTRW5/p/6aI
|
| 51 |
62a7Rfb9WZl0z75PZbk4id9idAPF1Gu35gAS1mEjncUlz/jC5pQlVB0kdF0F+feU
|
| 52 |
FIXfoXD7U4LZBIjCmD3fvf6GBaQN4M/i0ZKj56BnHzVUqMUkOzSSmMLc9M+TqQZR
|
| 53 |
dFG7GlgUrUz6G86XwXMY0OCu85lo8VVDE7bcDDK+Yh5RXr7ZQ7GozPQR25VJ8G2K
|
| 54 |
PIxIS4hIZ0+W+zuPqDs0skjWhcdpIlYGEV5p35GVzmiHqqyaDKd/WVuVM6e4xl+2
|
| 55 |
CrcWjy9OJnmyVOGmjtG3QJBlG6MIRbPpF1B2NYNLkk14Vnw/iDCRjkU28WzeyKlf
|
| 56 |
x9j6BCWLFP4g8StyW0e6f9aprg3/svD6XH84oPD3+8AfbBud5s7w4r+bL2UpDalU
|
| 57 |
PsdUmBLdEfMzQroZP9jYGGEtzyzLIAnO8WKmRn73Pi9Heg43TN7KdZJMqwDqu2ZM
|
| 58 |
Nzpm4xH0SK/iz6QlGMJ86hLkV2TdkU+KLUn0Bd8785hqw1ozdVZm0LhtygnluJij
|
| 59 |
pCrFnbomR7z9a8yvB1eLbnbbgd6Q8oKoVXM/h2ap0ncoz3tqaJ+9ccKryV4fOi3T
|
| 60 |
prdfHAfmIU1YJFYCvY6B
|
| 61 |
=i8Zv
|
| 62 |
-----END PGP SIGNATURE----- |
Archives