| 1 |
Just small, very small comments. To avoid being accused of bikeshedding, |
| 2 |
I'm totally fine if you don't apply any of them. It's entirely up to you. :) |
| 3 |
|
| 4 |
https://bugs.gentoo.org/show_bug.cgi?id=480826 : |
| 5 |
|
| 6 |
> if use directfb ; then |
| 7 |
> # since DirectFB can link against SDL and trigger a |
| 8 |
> # dependency loop, only link against DirectFB if it |
| 9 |
> # isn't broken #61592 |
| 10 |
> echo 'int main(){}' > directfb-test.c |
| 11 |
> $(tc-getCC) directfb-test.c -ldirectfb 2>/dev/null \ |
| 12 |
> && directfbconf="--enable-video-directfb" \ |
| 13 |
> || ewarn "Disabling DirectFB since libdirectfb.so is broken" |
| 14 |
> fi |
| 15 |
|
| 16 |
Suggestion: print what to do in the ewarn (or just reference the bug |
| 17 |
number in he ewarn so the user doesn't have to read the ebuild). |
| 18 |
|
| 19 |
> # --disable-threads broken |
| 20 |
|
| 21 |
If there is some reference why/how it is broken, it'd be great to |
| 22 |
reference it there (to avoid kind of cargo cult programming "it's here |
| 23 |
because it always was here, and it is probably still broken but nobody |
| 24 |
remembers how"). |
| 25 |
|
| 26 |
https://bugs.gentoo.org/show_bug.cgi?id=481796 : |
| 27 |
|
| 28 |
> RDEPEND=${DEPEND} |
| 29 |
> |
| 30 |
> S=${WORKDIR}/SDL2_mixer-${PV} |
| 31 |
|
| 32 |
Why no quotes? ("") |
| 33 |
|
| 34 |
https://bugs.gentoo.org/show_bug.cgi?id=481794 : |
| 35 |
|
| 36 |
> S=${WORKDIR}/${MY_P} |
| 37 |
|
| 38 |
Why no quotes? ("") |
| 39 |
|
| 40 |
> src_configure() { |
| 41 |
> econf \ |
| 42 |
> --disable-gui \ |
| 43 |
> $(use_enable static-libs static) |
| 44 |
> } |
| 45 |
|
| 46 |
Would it make sense to add USE flag to --enable-gui? |
| 47 |
|
| 48 |
https://bugs.gentoo.org/show_bug.cgi?id=481788 : |
| 49 |
|
| 50 |
> S=${WORKDIR}/SDL2_ttf-${PV} |
| 51 |
|
| 52 |
I suggest quotes (""). |
| 53 |
|
| 54 |
> src_install() { |
| 55 |
> emake DESTDIR="${D}" install || die |
| 56 |
> dodoc {CHANGES,README}.txt |
| 57 |
> use static-libs || prune_libtool_files --all |
| 58 |
> } |
| 59 |
|
| 60 |
In EAPI-5 die after emake is not needed. |
| 61 |
|
| 62 |
Again, these things are _tiny_ details, and it's entirely up to you what |
| 63 |
to do with it. I hope it'll be at least somewhat useful. And of course |
| 64 |
everything else looks good. :) |
| 65 |
|
| 66 |
Thank you for working on sdl2 bumps! |
| 67 |
|
| 68 |
Paweł |
Archives