Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-libs/libuv: libuv-1.2.1.ebuild ChangeLog

[Arfrever Frehtes Taifersar Arahesis]

2015-01-19 10:40 Jeroen Roovers napisał(a):
> On Fri, 16 Jan 2015 15:26:55 +0000
> hasufell <hasufell@g.o> wrote:
>
> > Patrick Lauer (patrick):
> > > patrick     15/01/16 04:16:55
> > >
> > >   Modified:             ChangeLog
> > >   Added:                libuv-1.2.1.ebuild
> > >   Log:
> > >   Bump
> > >
> >
> > I expect people to ask me for review if they bump any of my packages.
> > That includes QA team members.
>
> The only (QA) problem I see is the pointless removal of the ebuild in
> question and the subsequent addition of a pointless revision bump with
> no clue as to why it was removed or why the revision bump was required

$ diff -u1 libuv-1.2.1.ebuild libuv-1.2.1-r1.ebuild
--- libuv-1.2.1.ebuild
+++ libuv-1.2.1-r1.ebuild
@@ -2,3 +2,3 @@
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/dev-libs/libuv/Attic/libuv-1.2.1.ebuild,v 1.1 2015/01/16 04:16:55 patrick Exp $
+# $Header: /var/cvsroot/gentoo-x86/dev-libs/libuv/libuv-1.2.1-r1.ebuild,v 1.1 2015/01/16 15:47:31 hasufell Exp $
 
@@ -9,3 +9,3 @@
 DESCRIPTION="A new platform layer for Node"
-HOMEPAGE="https://github.com/joyent/libuv"
+HOMEPAGE="https://github.com/libuv/libuv"
 SRC_URI="https://github.com/libuv/libuv/archive/v${PV}.tar.gz -> ${P}.tar.gz"
@@ -17,3 +17,6 @@
 
-DEPEND="virtual/pkgconfig"
+DEPEND="
+       sys-devel/libtool
+       virtual/pkgconfig
+"
 
@@ -24,4 +27,4 @@
        sed -i \
-               -e '/libuv_la_CFLAGS/s#-g##' \
-               Makefile.am || die "fixing CFLAGS failed!"
+               -e '/CC_CHECK_CFLAGS_APPEND(\[-g\])/d' \
+               configure.ac || die "fixing CFLAGS failed!"
 


The broken libuv-1.2.1.ebuild was not disabling unwanted addition of -g to CFLAGS.
The fix for this problem affected installed files, so revision bump was required.

--
Arfrever Frehtes Taifersar Arahesis