Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Cc: Ulrich Mueller <ulm@g.o>, compnerd@g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/leafpad: ChangeLog leafpad-0.8.14.ebuild
Date: Sun, 30 Mar 2008 16:21:58
Message-Id: 200803301225.25148.vapier@gentoo.org
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/leafpad: ChangeLog leafpad-0.8.14.ebuild by Ulrich Mueller
1 On Sunday 30 March 2008, Ulrich Mueller wrote:
2 > >>>>> On Sat, 29 Mar 2008, Donnie Berkholz wrote:
3 > >
4 > > On 19:37 Sat 29 Mar , Saleem Abdulrasool (compnerd) wrote:
5 > >> 1.1 app-editors/leafpad/leafpad-0.8.14.ebuild
6 > >>
7 > >> src_compile() {
8 > >> econf --enable-chooser --enable-print $(use_enable emacs)
9 > >> emake
10 > >> }
11 > >
12 > > emake doesn't die on failure.
13 >
14 > And IMHO the "emacs" USE flag should not be used here:
15 >
16 > $ ./configure -hs
17 > Configuration of Leafpad 0.8.12:
18 >
19 > Optional Features:
20 > [...]
21 > --enable-emacs implement Emacs key theme (experimental)
22 >
23 > $ equery uses =leafpad-0.8.12
24 > [...]
25 > + + emacs : Adds support for GNU Emacs
26 >
27 > As its description says, the flag is intended for GNU Emacs support
28 > which is not the case here.
29
30 i think the USE flag makes sense. perhaps the description should be changed.
31 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies