Gentoo Archives: gentoo-dev

From: Donnie Berkholz <dberkholz@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Ebuild QA (was Re: "Trivial" commit reviews)
Date: Mon, 24 Sep 2007 09:34:43
Message-Id: 20070924092341.GL22279@supernova
In Reply to: [gentoo-dev] Ebuild QA (was Re: "Trivial" commit reviews) by Steve Long
1 On 09:55 Mon 24 Sep , Steve Long wrote:
2 > Donnie Berkholz wrote:
3 > > On 06:22 Mon 24 Sep , Thilo Bangert wrote:
4 > >> also, perhaps the more common ones should additionally be converted to
5 > >> repoman tests, if that is feasable.
6 > >
7 > > That might be reasonable for some cases, but it won't be perfect, and
8 > > won't even be possible for many.
9 > >
10 > Which are the cases you (and others ofc) think it would be reasonable for?
11
12 I don't think we've yet discovered what all the common cases are. As the
13 current top issues drop because people check for them, these reviews
14 will likely begin to reveal new top issues, as the quoting is now.
15
16 > ed(1) really is the tool to use for that -- g/RegEx/p does exactly what grep
17 > does, and there's no compatibility issue for FreeBSD vs Linux. (It's also a
18 > lot more capable than sed, and there really is no need for awk in this
19 > instance.)
20
21 The problem with using ed in Gentoo is that nobody (figuratively) knows
22 how to use it. This means nobody can spot problems with others' use of
23 it. Our standard set of ebuild tools is pretty much:
24
25 bash
26 grep
27 sed
28 awk
29
30 Even if it's not the most elegant solution technically, it's the one
31 that works best when you consider the bigger picture of our developers'
32 skills.
33
34 Thanks,
35 Donnie
36 --
37 gentoo-dev@g.o mailing list