| 1 |
Donnie Berkholz wrote: |
| 2 |
> On 06:22 Mon 24 Sep , Thilo Bangert wrote: |
| 3 |
>> also, perhaps the more common ones should additionally be converted to |
| 4 |
>> repoman tests, if that is feasable. |
| 5 |
> |
| 6 |
> That might be reasonable for some cases, but it won't be perfect, and |
| 7 |
> won't even be possible for many. |
| 8 |
> |
| 9 |
Which are the cases you (and others ofc) think it would be reasonable for? |
| 10 |
|
| 11 |
> So far, the only one I've seen that might work well for is quoting |
| 12 |
> around specific variables. You could do something like a grep for words |
| 13 |
> containing '${+D[^[:alnum:]-_]' (haven't tested that, just beginnings of |
| 14 |
> an idea) and the same for S and WORKDIR. |
| 15 |
> |
| 16 |
marienz mentioned something similar a few months ago, wrt allowing unquoted |
| 17 |
expansions for specific vars that are used in eg for loops (like A or |
| 18 |
SRC_URI) and not for any others. |
| 19 |
|
| 20 |
ed(1) really is the tool to use for that -- g/RegEx/p does exactly what grep |
| 21 |
does, and there's no compatibility issue for FreeBSD vs Linux. (It's also a |
| 22 |
lot more capable than sed, and there really is no need for awk in this |
| 23 |
instance.) |
| 24 |
|
| 25 |
1) http://bash-hackers.org/wiki/doku.php?id=howto:edit-ed |
| 26 |
|
| 27 |
|
| 28 |
-- |
| 29 |
gentoo-dev@g.o mailing list |
Archives