Gentoo Archives: gentoo-dev

From: Ciaran McCreesh <ciaran.mccreesh@××××××××××.com>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Review a new (unofficial) eclass
Date: Tue, 16 Jun 2009 17:24:05
Message-Id: 20090616182353.3c015fed@snowcone
In Reply to: [gentoo-dev] Review a new (unofficial) eclass by Nick
1 On Tue, 16 Jun 2009 15:06:02 +0100
2 Nick <gentoo-dev-list@××××××.uk> wrote:
3 > Please can you let me know what you think of the eclass & ebuilds;
4 > any suggestions, criticisms, questions etc? This is my first time
5 > writing an eclass, and to me it all feels quite nice and solid, but
6 > that's the sort of thing which could quickly and harshly disproved
7 > ;-)
8
9 You *really* shouldn't be messing around with things in DISTDIR the way
10 you are. That's just plain horrible. The only reason DISTDIR isn't
11 forcibly read-only is that the scm eclasses need to write to
12 subdirectories of it.
13
14 Just do your own unpack if you can't handle it.
15
16 Also, is that really the best way of generating SRC_URI? Can't you
17 remove the need to put anything in ebuilds?
18
19 --
20 Ciaran McCreesh

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] Review a new (unofficial) eclass Nick <gentoo-dev-list@××××××.uk>