| 1 |
-----BEGIN PGP SIGNED MESSAGE-----
|
| 2 |
Hash: SHA1
|
| 3 |
|
| 4 |
> In my opinion, the text "# @DESCRIPTION" in an eclass is more than |
| 5 |
> enough for readability, and setting DESCRIPTION only serves to |
| 6 |
> contaminate the environment. The is especially true for the following |
| 7 |
> eclasses that set the DESCRIPTION from the subject: |
| 8 |
> |
| 9 |
> ozzie eclass # grep 'DESCRIPTION="Based on the ' *.eclass |
| 10 |
> cannadic.eclass:DESCRIPTION="Based on the $ECLASS eclass" |
| 11 |
> confutils.eclass:DESCRIPTION="Based on the ${ECLASS} eclass" |
| 12 |
> embassy.eclass:DESCRIPTION="Based on the $ECLASS eclass" |
| 13 |
> eutils.eclass:DESCRIPTION="Based on the ${ECLASS} eclass" |
| 14 |
> games.eclass:DESCRIPTION="Based on the ${ECLASS} eclass" |
| 15 |
> gnatbuild.eclass:DESCRIPTION="Based on the ${ECLASS} eclass" |
| 16 |
> gnuconfig.eclass:DESCRIPTION="Based on the ${ECLASS} eclass" |
| 17 |
> libtool.eclass:DESCRIPTION="Based on the ${ECLASS} eclass" |
| 18 |
> linux-mod.eclass:DESCRIPTION="Based on the $ECLASS eclass" |
| 19 |
> nsplugins.eclass:DESCRIPTION="Based on the ${ECLASS} eclass" |
| 20 |
> perl-module.eclass:DESCRIPTION="Based on the $ECLASS eclass" |
| 21 |
> qmail.eclass:DESCRIPTION="Based on the ${ECLASS} eclass" |
| 22 |
> toolchain-funcs.eclass:DESCRIPTION="Based on the ${ECLASS} eclass" |
| 23 |
> |
| 24 |
> Although these are the ones that make me the most unhappy, I see no |
| 25 |
> purpose for setting DESCRIPTION in any eclass as it really serves no |
| 26 |
> purpose to source the eclass then source the ebuild 0.01s later and |
| 27 |
> overwrite the DESCRIPTION. Fixing this is not difficult, unlikely to |
| 28 |
> affect anything, but will help avoid one tiny little annoyance that |
| 29 |
> really looks like a relic from a time long long ago. |
| 30 |
|
| 31 |
Right, it forbids repoman perform DESCRIPTION.missing check
|
| 32 |
and makes no sense in multiple inheritance case.
|
| 33 |
|
| 34 |
metadata/md5-cache:LANG=C fgrep -R "Based on " .
|
| 35 |
./sys-fs/sysfsutils-2.1.0:DESCRIPTION=System Utilities Based on Sysfs
|
| 36 |
|
| 37 |
None of in-tree users relies on the value. Thus you can wipe them while
|
| 38 |
nobody is watching :]
|
| 39 |
|
| 40 |
- --
|
| 41 |
|
| 42 |
Sergei
|
| 43 |
-----BEGIN PGP SIGNATURE-----
|
| 44 |
Version: GnuPG v2.0.19 (GNU/Linux)
|
| 45 |
|
| 46 |
iEYEARECAAYFAlBUQ/UACgkQcaHudmEf86qP3gCfftVveos4vrjFbUFSfqauVjm1
|
| 47 |
8c8AnRS8K4NG5NttW79RN5P9aYWY+Pju
|
| 48 |
=oDKV
|
| 49 |
-----END PGP SIGNATURE----- |
Archives