Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

[Rémi Cardona]

David Leverton a écrit :
> On Friday 14 March 2008 07:14:23 Rémi Cardona wrote:
>>   - the gnome2 eclass now has a pkg_preinst, if you do multiple
>> inherits, make sure that gnome2_pkg_preinst is called too. The
>> _games_eclass_ is one of those.
>
> Maybe worth adding a dummy to the current version of the eclass so that
> ebuilds can be updated now, instead of suddenly all at once as soon as the
> new eclass is committed?

Good idea, I'll see what I can do there.

> Are you referring to the need to call gnome2_gconf_savelist in pkg_preinst if
> the ebuild/eclass wants to use the gconf functions?  What I said above goes
> here as well.

That's basically it, along with gnome2_icons_savelist.

>> #gnome2_pkg_prerm() {
>> #       gnome2_gconf_uninstall
>> #}
>
> Should this really be commented out?  If so, might be worth adding a comment
> explaining why - it's not clear whether it's disabled because it's broken, or
> not necessary, or whether ebuilds are expected to call gnome2_gconf_uninstall
> explicitly if they need to.

Yes, I'll add a comment, this functionality is broken, but we want to 
keep the code for future use.

> SCROLLKEEPER_UPDATE_BIN=${SCROLLKEEPER_UPDATE_BIN:="${ROOT}usr/bin/scrollkeeper-update"}
>
> Those aren't going to work with cross-compilation (which isn't well-supported
> by the current ebuild format, but best to be future-proof), since the
> executables in ${ROOT} won't be able to run on the build machine.

With Gnome 2.22 (app-text/rarian specifically), scrollkeeper-update is 
just a script (that's even just a no-op if I'm not mistaken). So all 
this scrollkeeper cruft will just become irrelevant as time goes on.

>>         export GCONF_CONFIG_SOURCE=$(${GCONFTOOL_BIN} --get-default-source)
>
> I confess I don't know much about gconf, but that looks as though it'll always
> return a path in /, not ${ROOT}, so it'll install the schemas in the /
> database.

IIRC, the path returned in --get-default-source should contain $ROOT 
because gconf was installed using $ROOT. So it should be safe. So far, 
no one has complained :)

Thanks a lot for your review.

-- 
Rémi Cardona
LRI, INRIA
remi.cardona@×××.fr
remi@g.o
-- 
gentoo-dev@l.g.o mailing list