Re: [gentoo-dev] [PATCH] skel.ebuild: Update comments for inherit, SLOT, KEYWORDS.

[Michał Górny]

W dniu nie, 31.12.2017 o godzinie 14∶31 +0100, użytkownik Ulrich Müller
napisał:
> epatch() is provided by epatch.eclass now. Also comment the inherit
> line, since not every ebuild will use it.
>
> Empty SLOT doesn't disable slots, but is outright illegal in all EAPIs.
> Similar for KEYWORDS="*", which isn't "deprecated" but invalid.
> ---
>  skel.ebuild | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/skel.ebuild b/skel.ebuild
> index 7ac9dfb7d6d8..4c19b1de4cb8 100644
> --- a/skel.ebuild
> +++ b/skel.ebuild
> @@ -13,9 +13,9 @@
>  EAPI=6
>
>  # inherit lists eclasses to inherit functions from. For example, an ebuild
> -# that needs the epatch function from eutils.eclass won't work without the
> +# that needs the epatch function from epatch.eclass won't work without the
>  # following line:
> -inherit eutils
> +#inherit epatch

Well, given that it's EAPI 6 and we do not want to encourage people to
use epatch there, I would prefer if we replaced that example with
something else. But it's just a wishful thinking here.

>  #
>  # eclasses tend to list descriptions of how to use their functions properly.
>  # take a look at /usr/portage/eclass/ for more examples.
> @@ -46,7 +46,7 @@ LICENSE=""
>  # of each SLOT and remove everything else.
>  # Note that normal applications should use SLOT="0" if possible, since
>  # there should only be exactly one version installed at a time.
> -# DO NOT USE SLOT=""! This tells Portage to disable SLOTs for this package.
> +# Do not use SLOT="", because the SLOT variable must not be empty.
>  SLOT="0"
>
>  # Using KEYWORDS, we can record masking information *inside* an ebuild
> @@ -63,8 +63,7 @@ SLOT="0"
>  # For binary packages, use -* and then list the archs the bin package
>  # exists for.  If the package was for an x86 binary package, then
>  # KEYWORDS would be set like this: KEYWORDS="-* x86"
> -# DO NOT USE KEYWORDS="*".  This is deprecated and only for backward
> -# compatibility reasons.
> +# Do not use KEYWORDS="*".  This is not valid in an ebuild context.
>  KEYWORDS="~x86"
>
>  # Comprehensive list of any and all USE flags leveraged in the ebuild,

LGTM.

-- 
Best regards,
Michał Górny