Gentoo Archives: gentoo-dev

From: "Andreas K. Hüttel" <dilfridge@g.o>
To: gentoo-dev@l.g.o
Cc: "Andreas K. Hüttel" <dilfridge@g.o>
Subject: [gentoo-dev] [PATCH 4/5] depend.apache.eclass: For EAPI=6, move initialization of APACHE_BASEDIR and APACHE_MODULESDIR into pkg_setup
Date: Thu, 08 Dec 2016 20:37:07
Message-Id: 20161208203632.2105-5-dilfridge@gentoo.org
In Reply to: [gentoo-dev] depend.apache.eclass rework, try 2 by "Andreas K. Hüttel"
1 ---
2 eclass/depend.apache.eclass | 35 ++++++++++++++++++++++++-----------
3 1 file changed, 24 insertions(+), 11 deletions(-)
4
5 diff --git a/eclass/depend.apache.eclass b/eclass/depend.apache.eclass
6 index a51ec55..8582396 100644
7 --- a/eclass/depend.apache.eclass
8 +++ b/eclass/depend.apache.eclass
9 @@ -40,17 +40,11 @@
10 # }
11 # @CODE
12
13 -inherit multilib
14 -
15 case ${EAPI:-0} in
16 0|2|3|4|5)
17 + inherit multilib
18 ;;
19 6)
20 - ewarn
21 - ewarn "EAPI=${EAPI} is not supported by depend.apache.eclass."
22 - ewarn "This means that ${CATEGORY}/${PF} is most likely buggy."
23 - ewarn "Please file a report on https://bugs.gentoo.org/"
24 - ewarn
25 ;;
26 *)
27 die "EAPI=${EAPI} is not supported by depend.apache.eclass"
28 @@ -84,7 +78,8 @@ esac
29 # @ECLASS-VARIABLE: APACHE_BASEDIR
30 # @DESCRIPTION:
31 # Path to the server root directory.
32 -# This variable is set by the want/need_apache functions.
33 +# This variable is set by the want/need_apache functions (EAPI=0 through 5)
34 +# or depend.apache_pkg_setup (EAPI=6 and later).
35
36 # @ECLASS-VARIABLE: APACHE_CONFDIR
37 # @DESCRIPTION:
38 @@ -104,7 +99,8 @@ esac
39 # @ECLASS-VARIABLE: APACHE_MODULESDIR
40 # @DESCRIPTION:
41 # Path where we install modules.
42 -# This variable is set by the want/need_apache functions.
43 +# This variable is set by the want/need_apache functions (EAPI=0 through 5)
44 +# or depend.apache_pkg_setup (EAPI=6 and later).
45
46 # @ECLASS-VARIABLE: APACHE_DEPEND
47 # @DESCRIPTION:
48 @@ -141,10 +137,19 @@ _init_apache2() {
49 APACHE_BIN="/usr/sbin/apache2"
50 APACHE_CTL="/usr/sbin/apache2ctl"
51 APACHE_INCLUDEDIR="/usr/include/apache2"
52 - APACHE_BASEDIR="/usr/$(get_libdir)/apache2"
53 APACHE_CONFDIR="/etc/apache2"
54 APACHE_MODULES_CONFDIR="${APACHE_CONFDIR}/modules.d"
55 APACHE_VHOSTS_CONFDIR="${APACHE_CONFDIR}/vhosts.d"
56 +
57 + case ${EAPI:-0} in
58 + 0|2|3|4|5)
59 + _init_apache2_late
60 + ;;
61 + esac
62 +}
63 +
64 +_init_apache2_late() {
65 + APACHE_BASEDIR="/usr/$(get_libdir)/apache2"
66 APACHE_MODULESDIR="${APACHE_BASEDIR}/modules"
67 }
68
69 @@ -173,7 +178,15 @@ depend.apache_pkg_setup() {
70 local myiuse=${1:-apache2}
71 if has ${myiuse} ${IUSE}; then
72 if use ${myiuse}; then
73 - _init_apache2
74 + case ${EAPI:-0} in
75 + 0|2|3|4|5)
76 + _init_apache2
77 + ;;
78 + *)
79 + _init_apache2
80 + _init_apache2_late
81 + ;;
82 + esac
83 else
84 _init_no_apache
85 fi
86 --
87 2.11.0.rc2