1 |
On Mon, Jul 01, 2013 at 08:45:16PM +0200, Tom Wijsman wrote: |
2 |
> > > Q: What about my stable server? I really don't want to run this |
3 |
> > > stuff! |
4 |
> > > |
5 |
> > > A: These options would depend on !CONFIG_VANILLA or |
6 |
> > > CONFIG_EXPERIMENTAL |
7 |
> > |
8 |
> > What is CONFIG_VANILLA? I don't see that in the upstream kernel tree |
9 |
> > at all. |
10 |
> > |
11 |
> > CONFIG_EXPERIMENTAL is now gone from upstream, so you are going to |
12 |
> > have a problem with this. |
13 |
> |
14 |
> Earlier I mentioned "2) These feature should depend on a non-vanilla / |
15 |
> experimental option." which is an option we would introduce under the |
16 |
> Gentoo distribution menu section. |
17 |
|
18 |
Distro-specific config options, great :( |
19 |
|
20 |
> > > which would be disabled by default, therefore if you keep this |
21 |
> > > option the way it is on your stable server; it won't affect you. |
22 |
> > |
23 |
> > Not always true. Look at aufs as an example. It patches the core |
24 |
> > kernel code in ways that are _not_ accepted upstream yet. Now you all |
25 |
> > are running that modified code, even if you don't want aufs. |
26 |
> |
27 |
> Earlier I mentioned "3) The patch should not affect the build by |
28 |
> default."; if it does, we have to adjust it to not do that, this is |
29 |
> something that can be easily scripted. It's just a matter of embedding |
30 |
> each + block in the diff with a config check and updating the counts. |
31 |
|
32 |
Look at aufs as a specific example of why you can't do that, otherwise, |
33 |
don't you think that the aufs developer(s) wouldn't have done so? |
34 |
|
35 |
The goal of "don't touch any other kernel code" is a very good one, but |
36 |
not always true for these huge out-of-tree kernel patches. Usually that |
37 |
is the main reason why these patches aren't merged upstream, because |
38 |
those changes are not acceptable. |
39 |
|
40 |
So be very careful here, you are messing with things that are rejected |
41 |
by upstream. |
42 |
|
43 |
greg k-h |