Gentoo Archives: gentoo-dev

From: "Marijn Schouten (hkBst)" <hkBst@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: New eclass: cmake-utils.eclass
Date: Fri, 09 Nov 2007 17:46:56
Message-Id: 47349CBF.7040802@gentoo.org
In Reply to: Re: [gentoo-dev] Re: New eclass: cmake-utils.eclass by "René 'Necoro' Neumann"
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 � wrote:
5 > Wulf C. Krueger schrieb:
6 >> On Friday, 09. November 2007 10:10:42 Rený 'Necoro' Neumann wrote:
7 >>> But as I think, that the uppercase version is the common behavior here,
8 >>> it should not need this extra "PYTHON". :) That's why the patch ;)
9 >> Actually, the mixed-case is what we have encountered in most cases.
10 >
11 >> Furthermore, as you stated correctly yourself, cmake is case-sensitive and
12 >> a patch that works around that fact only to have one parameter less for a
13 >> function doesn't really make much sense in my book.
14 >
15 > Hmm ... ok - if you say, that more applications used the mixed case
16 > versions, the current version is ok :)
17 > I did not want to reduce one parameter, but when I first used this
18 > eclass function, I assumed, that it will do the right thing (that is:
19 > make it uppercase). It did not do so - that's why the patch ;).
20 >
21 > Another way would be to enhance the comment and state explicitly that it
22 > takes the useflag literally and does not do any case transition :)
23
24 Please don't reuse other people's digital signatures, Necoro.
25
26 Marijn
27
28 - --
29 Marijn Schouten (hkBst), Gentoo Lisp project, Gentoo ML
30 <http://www.gentoo.org/proj/en/lisp/>, #gentoo-{lisp,ml} on FreeNode
31 -----BEGIN PGP SIGNATURE-----
32 Version: GnuPG v2.0.7 (GNU/Linux)
33 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
34
35 iD8DBQFHNJy/p/VmCx0OL2wRApycAJwLttjtkPEEzEEkM0XlNg93FCzgCgCgtkRU
36 /HTtrpUXuHV4jjcQ8qGqlSM=
37 =K51B
38 -----END PGP SIGNATURE-----
39 --
40 gentoo-dev@g.o mailing list

Replies

Subject Author
Re: [gentoo-dev] Re: New eclass: cmake-utils.eclass "Marijn Schouten (hkBst)" <hkBst@g.o>