| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
Marijn Schouten (hkBst) wrote: |
| 5 |
> ý wrote: |
| 6 |
>> Wulf C. Krueger schrieb: |
| 7 |
>>> On Friday, 09. November 2007 10:10:42 Rený 'Necoro' Neumann wrote: |
| 8 |
>>>> But as I think, that the uppercase version is the common behavior here, |
| 9 |
>>>> it should not need this extra "PYTHON". :) That's why the patch ;) |
| 10 |
>>> Actually, the mixed-case is what we have encountered in most cases. |
| 11 |
>>> Furthermore, as you stated correctly yourself, cmake is case-sensitive and |
| 12 |
>>> a patch that works around that fact only to have one parameter less for a |
| 13 |
>>> function doesn't really make much sense in my book. |
| 14 |
>> Hmm ... ok - if you say, that more applications used the mixed case |
| 15 |
>> versions, the current version is ok :) |
| 16 |
>> I did not want to reduce one parameter, but when I first used this |
| 17 |
>> eclass function, I assumed, that it will do the right thing (that is: |
| 18 |
>> make it uppercase). It did not do so - that's why the patch ;). |
| 19 |
> |
| 20 |
>> Another way would be to enhance the comment and state explicitly that it |
| 21 |
>> takes the useflag literally and does not do any case transition :) |
| 22 |
> |
| 23 |
> Please don't reuse other people's digital signatures, Necoro. |
| 24 |
|
| 25 |
Never mind, I take it back. |
| 26 |
|
| 27 |
Marijn |
| 28 |
|
| 29 |
- -- |
| 30 |
Marijn Schouten (hkBst), Gentoo Lisp project, Gentoo ML |
| 31 |
<http://www.gentoo.org/proj/en/lisp/>, #gentoo-{lisp,ml} on FreeNode |
| 32 |
-----BEGIN PGP SIGNATURE----- |
| 33 |
Version: GnuPG v2.0.7 (GNU/Linux) |
| 34 |
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org |
| 35 |
|
| 36 |
iD8DBQFHNJ4Qp/VmCx0OL2wRAlNSAJwMzJyjMgcywE05LQSJIIvlZp8L5ACfUEnU |
| 37 |
d0YFSB4eC7r+dHvVY1j4y9A= |
| 38 |
=qJmh |
| 39 |
-----END PGP SIGNATURE----- |
| 40 |
-- |
| 41 |
gentoo-dev@g.o mailing list |
Archives