Gentoo Archives: gentoo-dev

From: "Robin H. Johnson" <robbat2@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] Support Makefiles that set variables to a non-static value
Date: Thu, 09 Sep 2021 17:21:43
Message-Id: robbat2-20210909T171758-305427581Z@orbis-terrarum.net
In Reply to: [gentoo-dev] [PATCH] Support Makefiles that set variables to a non-static value by Mike Pagano
1 On Wed, Sep 01, 2021 at 02:44:11PM -0400, Mike Pagano wrote:
2 > Previously, the kernel Makefile had to define version variables
3 > as static string literals to be read.
4 > This change will allow varibles defined as non-static values
5 > to be read.
6 Hi,
7
8 This change has broken infra systems where /usr/src/ is empty because
9 they use a binary kernel. /proc/config.gz does exist on those systems for this
10 use case.
11
12 Specifically, any package that uses linux-info to issues warnings via the '~'
13 syntax now fails because "getfilevar_noexec VERSION ..." returns empty string.
14
15 * Determining the location of the kernel source code
16 * Unable to find kernel sources at /usr/src/linux
17 * Please make sure that /usr/src/linux points at your running kernel,
18 * (or the kernel you wish to build against).
19 * Alternatively, set the KERNEL_DIR environment variable to the kernel sources location
20 * Unable to calculate Linux Kernel version for build, attempting to use running version
21 * ERROR: app-emulation/docker-20.10.7::gentoo failed (setup phase):
22 * Unable to determine any Linux Kernel version, please report a bug
23 *
24 * Call stack:
25 * ebuild.sh, line 127: Called pkg_setup
26 * docker-20.10.7.ebuild, line 110: Called kernel_is 'lt' '4' '5'
27 * linux-info.eclass, line 405: Called linux-info_get_any_version
28 * linux-info.eclass, line 678: Called die
29 * The specific snippet of code:
30 * die "Unable to determine any Linux Kernel version, please report a bug"
31
32 I'd like to propose that we revert the original CVS change that supported the fallback to getfilevar_noexec:
33 https://gitweb.gentoo.org/repo/gentoo/historical.git/commit/eclass/linux-info.eclass?id=ab160a941f5f52c95b47129d3243c693b05401e5
34
35 --
36 Robin Hugh Johnson
37 Gentoo Linux: Dev, Infra Lead, Foundation Treasurer
38 E-Mail : robbat2@g.o
39 GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
40 GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies