Gentoo Archives: gentoo-dev

From: "Miroslav Šulc (fordfrog)" <fordfrog@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.5-r1.ebuild netbeans-6.5.ebuild
Date: Sun, 23 Nov 2008 17:14:27
Message-Id: 49298F25.5000405@gentoo.org
In Reply to: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.5-r1.ebuild netbeans-6.5.ebuild by Jeremy Olexa
1 Thank you both for the suggestions, I fixed these issues in updated
2 netbeans-6.5-r1.
3
4 Miroslav Šulc (fordfrog)
5 Gentoo Java Team
6
7 Jeremy Olexa napsal(a):
8 > Peter Volkov wrote:
9 >> В Сбт, 22/11/2008 в 18:11 +0000, Miroslav Sulc (fordfrog) пишет:
10 >>> fordfrog 08/11/22 18:11:25
11 >>> Added: netbeans-6.5-r1.ebuild
12 >>> Log: netbeans compiles fine even with JDK 1.6 so I dropped the
13 >>> restriction on JDK, also commons-fileupload linking fixed
14 >>
15 >>> Index: netbeans-6.5-r1.ebuild
16 >>> ===================================================================
17 >>> pkg_setup() {
18 >>> if use netbeans_modules_apisupport && ! ( use
19 >>> netbeans_modules_harness && use netbeans_modules_ide && use
20 >>> netbeans_modules_java ) ; then
21 >>> eerror "'apisupport' USE flag requires 'harness', 'ide' and
22 >>> 'java' USE flags"
23 >
24 > Additionally, 'apisupport', 'harness', 'ide' and 'java' are not USE
25 > flags. You have to set NETBEANS_MODULES, not USE. You can easily test
26 > this by trying "NETBEANS_MODULES="apisupport" USE="java" emerge -pv
27 > netbeans" and see that netbeans_modules_java does not get set.
28 > -Jeremy
29 >
30 >>> exit 1
31 >>> fi
32 >>
33 >> Why do you use exit 1 instead of die?
34 >>
35 >>> local tmpfileplatform="${T}/platform.txt"
36 >>> cat ${tmpfile} | grep -v "libs.jna/external/jna-3.0.2.jar" >
37 >>> ${tmpfileplatform}
38 >>> mv ${tmpfileplatform} ${tmpfile}
39 >>
40 >> grep can read files on it's own so no need for cat file | grep... Also
41 >> possibly
42 >>
43 >> sed -e "/libs\.jna\/external\/jna-3\.0\.2\.jar/d" -i ${tmpfile}
44 >>
45 >> will work better here and in some other places...
46 >>
47 >
48 >