Gentoo Archives: gentoo-dev

From: Jeremy Olexa <darkside@g.o>
To: gentoo-dev@l.g.o
Cc: fordfrog@g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.5-r1.ebuild netbeans-6.5.ebuild
Date: Sat, 22 Nov 2008 19:47:14
Message-Id: 492861BE.8000905@gentoo.org
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.5-r1.ebuild netbeans-6.5.ebuild by Peter Volkov
1 Peter Volkov wrote:
2 > В Сбт, 22/11/2008 в 18:11 +0000, Miroslav Sulc (fordfrog) пишет:
3 >> fordfrog 08/11/22 18:11:25
4 >> Added: netbeans-6.5-r1.ebuild
5 >> Log: netbeans compiles fine even with JDK 1.6 so I dropped the restriction on JDK, also commons-fileupload linking fixed
6 >
7 >> Index: netbeans-6.5-r1.ebuild
8 >> ===================================================================
9 >> pkg_setup() {
10 >> if use netbeans_modules_apisupport && ! ( use netbeans_modules_harness && use netbeans_modules_ide && use netbeans_modules_java ) ; then
11 >> eerror "'apisupport' USE flag requires 'harness', 'ide' and 'java' USE flags"
12
13 Additionally, 'apisupport', 'harness', 'ide' and 'java' are not USE
14 flags. You have to set NETBEANS_MODULES, not USE. You can easily test
15 this by trying "NETBEANS_MODULES="apisupport" USE="java" emerge -pv
16 netbeans" and see that netbeans_modules_java does not get set.
17 -Jeremy
18
19 >> exit 1
20 >> fi
21 >
22 > Why do you use exit 1 instead of die?
23 >
24 >> local tmpfileplatform="${T}/platform.txt"
25 >> cat ${tmpfile} | grep -v "libs.jna/external/jna-3.0.2.jar" > ${tmpfileplatform}
26 >> mv ${tmpfileplatform} ${tmpfile}
27 >
28 > grep can read files on it's own so no need for cat file | grep... Also possibly
29 >
30 > sed -e "/libs\.jna\/external\/jna-3\.0\.2\.jar/d" -i ${tmpfile}
31 >
32 > will work better here and in some other places...
33 >

Replies