Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: aballier@g.o
Subject: Re: [gentoo-dev] [PATCH 2/2] Use new multilib flags in autotools-multilib.
Date: Sat, 26 Jan 2013 17:06:18
Message-Id: 20130126180632.327e105e@pomiocik.lan
In Reply to: Re: [gentoo-dev] [PATCH 2/2] Use new multilib flags in autotools-multilib. by Alexis Ballier
1 On Sat, 26 Jan 2013 12:30:16 -0300
2 Alexis Ballier <aballier@g.o> wrote:
3
4 > On Sat, 26 Jan 2013 16:08:45 +0100
5 > Michał Górny <mgorny@g.o> wrote:
6 >
7 > > On Sat, 26 Jan 2013 11:54:44 -0300
8 > > Alexis Ballier <aballier@g.o> wrote:
9 > >
10 > > > On Sat, 26 Jan 2013 13:11:41 +0100
11 > > > Michał Górny <mgorny@g.o> wrote:
12 > > >
13 > > > > > (maybe protect it with has_multilib_profile if you wish)
14 > > > >
15 > > > > Well, the current code assumes that no flags == non-multilib
16 > > > > profile.
17 > > >
18 > > > .. and I hit send to quickly:
19 > > > coming back to the skype example, with this assumption, on x86
20 > > > libitneeds will have no abi useflag enabled while on amd64 it'll
21 > > > have abi_x86_32, so you'll end with deps like: x86? ( libitneeds
22 > > > ) !x86? ( libitneeds[abi_x86_32] )
23 > >
24 > > Hmm, maybe we should make 'plain x86' use.force the abi_x86_32 flag
25 > > (though keeping it hidden). Then the following dep will work for both
26 > > arches:
27 > >
28 > > libitneeds[abi_x86_32]
29 >
30 > yep, that's the best thing to do IMHO, but then if you want no multilib
31 > -> returns empty list then you'll have to check it with
32 > has_multilib_profile :)
33
34 Is this really necessary? AFAIU from the endclass standpoint there's
35 no real difference between non-multilib build and build for one ABI.
36 I could even make the multilib code paths used only when at least 2 ABIs
37 are enabled.
38
39 --
40 Best regards,
41 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies