| 1 |
On Sat, 26 Jan 2013 18:06:32 +0100 |
| 2 |
Michał Górny <mgorny@g.o> wrote: |
| 3 |
|
| 4 |
> On Sat, 26 Jan 2013 12:30:16 -0300 |
| 5 |
> Alexis Ballier <aballier@g.o> wrote: |
| 6 |
> |
| 7 |
> > On Sat, 26 Jan 2013 16:08:45 +0100 |
| 8 |
> > Michał Górny <mgorny@g.o> wrote: |
| 9 |
> > |
| 10 |
> > > On Sat, 26 Jan 2013 11:54:44 -0300 |
| 11 |
> > > Alexis Ballier <aballier@g.o> wrote: |
| 12 |
> > > |
| 13 |
> > > > On Sat, 26 Jan 2013 13:11:41 +0100 |
| 14 |
> > > > Michał Górny <mgorny@g.o> wrote: |
| 15 |
> > > > |
| 16 |
> > > > > > (maybe protect it with has_multilib_profile if you wish) |
| 17 |
> > > > > |
| 18 |
> > > > > Well, the current code assumes that no flags == non-multilib |
| 19 |
> > > > > profile. |
| 20 |
> > > > |
| 21 |
> > > > .. and I hit send to quickly: |
| 22 |
> > > > coming back to the skype example, with this assumption, on x86 |
| 23 |
> > > > libitneeds will have no abi useflag enabled while on amd64 it'll |
| 24 |
> > > > have abi_x86_32, so you'll end with deps like: x86? ( libitneeds |
| 25 |
> > > > ) !x86? ( libitneeds[abi_x86_32] ) |
| 26 |
> > > |
| 27 |
> > > Hmm, maybe we should make 'plain x86' use.force the abi_x86_32 |
| 28 |
> > > flag (though keeping it hidden). Then the following dep will work |
| 29 |
> > > for both arches: |
| 30 |
> > > |
| 31 |
> > > libitneeds[abi_x86_32] |
| 32 |
> > |
| 33 |
> > yep, that's the best thing to do IMHO, but then if you want no |
| 34 |
> > multilib -> returns empty list then you'll have to check it with |
| 35 |
> > has_multilib_profile :) |
| 36 |
> |
| 37 |
> Is this really necessary? AFAIU from the endclass standpoint there's |
| 38 |
> no real difference between non-multilib build and build for one ABI. |
| 39 |
> I could even make the multilib code paths used only when at least 2 |
| 40 |
> ABIs are enabled. |
| 41 |
|
| 42 |
I don't think it's necessary, but that's what your function had as a |
| 43 |
spec :) |
| 44 |
You could probably just use one code path, since, like you said, |
| 45 |
non-multilib is multilib with only one abi :) |
| 46 |
|
| 47 |
(not sure if it's safe to do non-multilib when there's only one abi, it |
| 48 |
may not be the default abi and need multilib_toolchain_setup) |
| 49 |
|
| 50 |
by the way, you'd probably want _autotools-multilib_get_enabled_abis to |
| 51 |
return the default ABI last with the same trick as get_all_abis so that |
| 52 |
in make install the default ABI gets 'preference' as it overwrites the |
| 53 |
others upon collision (it should, in theory, not matter but think |
| 54 |
about installed headers that get processed by autotools) |
Archives