Re: [gentoo-dev] Committing straight to stable

[Diego 'Flameeyes' Pettenò]

On Sunday 24 April 2005 23:08, Francesco Riosa wrote:
> Also if who approves is _not_ the mentor / sane a 4 eyes check is always
> a good thing (TM) it's the way kernel develop is going from years now,
> right?
I think that doing something like that, surely will increase safety, but will 
also drive gentoo out of the world.

We have already too many packages which needs maintainers, and having to 
double-check every commit can be very very slow, because if there's too few 
people doing the second check, the bottleneck will stop everything being 
fixed, changed, updated.

Another problem is that there are tons of commits everyday, some of them are 
just trivials. I'm a new developer, but still today i did at least 10 
commits, if I counted them all. Some of them was just ~amd64 markings, other 
were fixes and version bumps. Some of them can't be tested, would require 
mergers to try the change locally and that could be really long, as to test 
some of them I needed to rebuild at least 6 packages. Also when keywording is 
concerned, after some time seeing similar patches you just can't say the 
differences between them.

I've done a couple of errors in this week I worked on gentoo, yes, but I was 
able to fix them asap. They was mainly trivial errors which I really have 
overseen (a ! not separed by space, an $Id: $ in a patch); probably 
double-checking them could have fixed them, but like so applying a security 
patch would have took surely more than just the about 40 minutes it took.

-- 
Diego "Flameeyes" Pettenò
Gentoo Developer (Gentoo/FreeBSD, Video, Gentoo/AMD64)

http://dev.gentoo.org/~flameeyes/