1 |
On Wed, Aug 31, 2016 at 11:09 PM, Mike Gilbert <floppym@g.o> wrote: |
2 |
> On Wed, Aug 31, 2016 at 12:52 PM, Alexis Ballier <aballier@g.o> wrote: |
3 |
>> On Sun, 28 Aug 2016 19:28:48 +0200 |
4 |
>> "Paweł Hajdan, Jr." <phajdan.jr@g.o> wrote: |
5 |
>> |
6 |
>>> D. Patch chromium not to require newer ffmpeg |
7 |
>> |
8 |
>> |
9 |
>> You can use the attached patch. Quick test on youtube showed it works. |
10 |
> |
11 |
> Nice! Testing this now. |
12 |
|
13 |
The code you have disabled seems to be comparing color space id values |
14 |
as defined in src/ui/gfx/color_space.h to the equivalent values in the |
15 |
ffmpeg API. I would assume this is because some chromium code uses |
16 |
them interchangeably. |
17 |
|
18 |
What happens if we pass one of those ids to an ffmpeg function that |
19 |
doesn't understand it? I'm afraid this might break in some subtle way. |