Gentoo Archives: gentoo-dev

From: Alexis Ballier <aballier@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] autotools-multilib: wrapper eclass for multilib builds.
Date: Tue, 25 Sep 2012 11:38:42
Message-Id: 20120925083732.387b73ae@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] autotools-multilib: wrapper eclass for multilib builds. by Matt Turner
1 On Mon, 24 Sep 2012 17:44:33 -0700
2 Matt Turner <mattst88@g.o> wrote:
3
4 > On Mon, Sep 24, 2012 at 3:22 PM, Alexis Ballier <aballier@g.o>
5 > wrote:
6 > > On Tue, 25 Sep 2012 00:10:21 +0200
7 > > Michał Górny <mgorny@g.o> wrote:
8 > >
9 > >> On Mon, 24 Sep 2012 18:59:14 -0300
10 > >> Alexis Ballier <aballier@g.o> wrote:
11 > >>
12 > >> > On Mon, 24 Sep 2012 23:51:27 +0200
13 > >> > Michał Górny <mgorny@g.o> wrote:
14 > >> >
15 > >> > > On Mon, 24 Sep 2012 18:19:43 -0300
16 > >> > > Alexis Ballier <aballier@g.o> wrote:
17 > >> > >
18 > >> > > > you dont need this, the PM has already done the work for you:
19 > >> > > > call directly the relevant function.
20 > >> > > >
21 > >> > > > src_multilib_compile() {
22 > >> > > > forall ABIS; do
23 > >> > > > prepare ABI variables
24 > >> > > > src_compile
25 > >> > > > done
26 > >> > > > }
27 > >> > >
28 > >> > > Err, what? Who calls the function? Where?
29 > >> >
30 > >> > bash. here.
31 > >>
32 > >> How can an eclass call a phase function while eclass needs to be
33 > >> called from the phase function to call the phase function...?
34 > >>
35 > >
36 > > Read again. Esp. the part you deleted.
37 > > I never said it should do this, on purpose...
38 > >
39 >
40 > I'm especially confused by what your point is. I can't see how your
41 > snippet could ever work, and you're being evasive about answering
42 > that.
43 >
44
45 both of you are putting words in my mouth then: obviously, if you call
46 your eclass multilib and the above function multilib_src_compile and
47 then pass it through EXPORT_FUNCTIONS, then it will loop.
48
49 let me copy paste what i wrote for you:
50
51 """
52 then, in a future EAPI, let the PM call src_multilib_compile instead
53 of src_compile if multilib is requested.
54 """
55
56 nothing more...