| 1 |
On Sat, Aug 14, 2010 at 03:35:34PM +0300, Alexis Ballier wrote: |
| 2 |
> On Saturday 07 August 2010 00:21:39 Markos Chandras (hwoarang) wrote: |
| 3 |
> > hwoarang 10/08/06 21:21:39 |
| 4 |
> > |
| 5 |
> > Modified: ChangeLog |
| 6 |
> > Added: mlt-0.5.4-r1.ebuild |
| 7 |
> > Log: |
| 8 |
> > Respect {C,LD}FLAGS when building shared library. Bug #308873 |
| 9 |
> > (Portage version: 2.2_rc67/cvs/Linux x86_64) |
| 10 |
> |
| 11 |
> While fixing bugs can't be bad and I thank you for doing it, I can see a |
| 12 |
> couple of important quality problems in this commit: |
| 13 |
> |
| 14 |
> - There is absolutely no reference to any patch sent upstream and I have not |
| 15 |
> seen anything on the upstream dev ml. |
| 16 |
Thats because I didn't. I've fixed more than 40 bug wrt LDFLAGS. Do you |
| 17 |
expect me to subscribe to 40 different ML and send them upstream? The |
| 18 |
patch is there, the maintainer is CC on the bug. All he has to do it to |
| 19 |
send this damn patch to upstream. I only care |
| 20 |
about the QA status on tree. Most of them just use my patches and |
| 21 |
contact upstream themselves. If this doesn't apply for you just let me |
| 22 |
know. |
| 23 |
> - If you are not in cc of the gentoo bug nor in the herd alias, please cc |
| 24 |
> yourself on the bug. |
| 25 |
> - Please close the bugs, even the dupes (and apply previous point to the dupes |
| 26 |
> too). |
| 27 |
> - That way you'll be able to quickly fix (apparently, I didn't check) obvious |
| 28 |
> mistakes [1]. |
| 29 |
> - You'll have to do a rev. bump for *FLAGS respect, please also check if you |
| 30 |
> can avoid it by doing a version bump instead. |
| 31 |
Well not always. If something is on ~testing then I don't think I should |
| 32 |
"spam" the tree with revbumps. Stable users are my first priority so |
| 33 |
unless something is on stable branch, I fix it as it is. I don't want to |
| 34 |
version bump anything because I don't want to mess with anyones |
| 35 |
packages. I only do QA fixing. If you have problem touching your |
| 36 |
packages just say it |
| 37 |
> |
| 38 |
> |
| 39 |
> A. |
| 40 |
> |
| 41 |
> |
| 42 |
> |
| 43 |
> [1] https://bugs.gentoo.org/show_bug.cgi?id=332523 |
| 44 |
|
| 45 |
-- |
| 46 |
Markos Chandras (hwoarang) |
| 47 |
Gentoo Linux Developer |
| 48 |
Web: http://hwoarang.silverarrow.org |
Archives