Gentoo Archives: gentoo-genkernel

From: "Rick \\\"Zero_Chaos\\\" Farina" <zerochaos@g.o>
To: gentoo-genkernel@l.g.o
Subject: Re: [gentoo-genkernel] [PATCH] e2fsprogs
Date: Mon, 24 Sep 2012 13:55:43
Message-Id: 5060666B.7060707@gentoo.org
In Reply to: Re: [gentoo-genkernel] [PATCH] e2fsprogs by Sebastian Pipping
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 On 09/23/2012 06:35 PM, Sebastian Pipping wrote:
5 > On 08/24/2012 10:38 PM, Rick "Zero_Chaos" Farina wrote:
6 >> This is as close as I can get to mimicking blkid style inclusion of
7 >> the e2fs progs that I need. I see two potential issues. 1.) This
8 >> isn't really conditional in any way afaict 2.) I *need* the e2fs
9 >> progs for other parts of my patchset but if e2fsprogs are not
10 >> installed on the system won't this fail horribly? Do we add
11 >> e2fsprogs to the rdep of the ebuild or what?
12 >
13 > As e2fsprogs are in DEPEND already, I don't see a problem with adding
14 > them to RDEPEND, too.
15 >
16 > Patch applied (with modifications) now:
17 > http://git.overlays.gentoo.org/gitweb/?p=proj/genkernel.git;a=commitdiff;h=c9a61ce2c722eec0a6d511914304186ddefb91fd
18 >
19 That is fantastic thanks. I had most recently submitted this version of
20 the patch which included the ability to add e2fstools optionally instead
21 of always. ryao had been testing for me and found that I messed up
22 somewhere and it was never actually including e2fstools. Anyway I've
23 not had the time recently to find the issue but here is the full patch
24 if you can find the typo it is feature complete if not for the fact that
25 the on/off switch appears to be stuck on off. I tried to copy existing
26 code style but can't honestly say I understood it well.
27
28 Thanks,
29 Zero
30 -----BEGIN PGP SIGNATURE-----
31 Version: GnuPG v2.0.19 (GNU/Linux)
32 Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
33
34 iQIcBAEBAgAGBQJQYGZrAAoJEKXdFCfdEflKy88QALpK9NFuEpfTWcV2+O4aF83H
35 tDGTsr0qaOkT+vXROVu2EfNxvdpgADO/CdCASDnUIOsKVj13zxTBDWonx7YSDZAe
36 L4bZ1Y3ALyYrY2x3LUfNGQxp7tGuINoXwVmiVfzO21peUQhYDhoVB/u5Yeovz9xJ
37 PQHi2iJ6ngumrAoMz7H7aaGg7MuXkoPG74Mvpdly70E7f88p+7m7yzsRM8DecvSK
38 bJMEVvopfohz3dy3wcgrum2SdXhnSzmrTODYoZGIdpyMsq4irv1QwQ2UpZ/dL8Y6
39 M6uaFYyZSsqixjOEvcR75qTTQH2wv8BYWVUunPjK6nok01Scd2kf1huBY+zJJUQK
40 kfHT9T7mRYLrqXiUDOTny2HGFxh7hWetqjc9otVccpB4z3WjFmJuuAaDwe/Yi89i
41 SVlrMT1JIoC/usebLn3qUTT4DWXDvv3fNtsOzNd2fcUVohfPGdoJJ2sfj1hDszOi
42 lRFw5PeJtyc3xmpwgEGawc68qFtfd2NjVOp7NS2QThBw6CPCF5oXYv3NJsps9GzN
43 Hr8qRcTFuWJRZ5VpDn2uZlfcr/xahLh7yI2Cib6fEXsXNcBffiz41MLZGKv7veEk
44 Ga+UdbICVjBTqGlmTxvI3xkyVKugB/8Tec6Wabj5kLEjqgVQFtxPOIQ/A/ePSj4A
45 rT6YewplOPTdcCbXXBOS
46 =KiUi
47 -----END PGP SIGNATURE-----

Attachments

File name MIME type
0001-Added-support-for-e2fsprogs-back-in.patch text/x-patch

Replies

Subject Author
Re: [gentoo-genkernel] [PATCH] e2fsprogs Sebastian Pipping <sping@g.o>